feat(native-filters): add refresh button to default value picker #14375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
commented
Apr 27, 2021
Comment on lines
+179
to
+224
| const refreshHandler = () => { | ||
| if (!hasDataset || !formFilter?.dataset?.value) { | ||
| forceUpdate(); | ||
| return; | ||
| } | ||
| const formData = getFormData({ | ||
| datasetId: formFilter?.dataset?.value, | ||
| groupby: formFilter?.column, | ||
| defaultValue: formFilter?.defaultValue, | ||
| ...formFilter, | ||
| }); | ||
| setNativeFilterFieldValues(form, filterId, { | ||
| defaultValueQueriesData: null, | ||
| isDataDirty: false, | ||
| }); | ||
| forceUpdate(); | ||
| getChartDataRequest({ | ||
| formData, | ||
| force: false, | ||
| requestParams: { dashboardId: 0 }, | ||
| }).then(response => { | ||
| if (isFeatureEnabled(FeatureFlag.GLOBAL_ASYNC_QUERIES)) { | ||
| // deal with getChartDataRequest transforming the response data | ||
| const result = 'result' in response ? response.result[0] : response; | ||
| waitForAsyncData(result) | ||
| .then((asyncResult: ChartDataResponseResult[]) => { | ||
| setNativeFilterFieldValues(form, filterId, { | ||
| defaultValueQueriesData: asyncResult, | ||
| }); | ||
| forceUpdate(); | ||
| }) | ||
| .catch((error: ClientErrorObject) => { | ||
| // TODO: show error once this logic is moved into new NativeFilter | ||
| // component | ||
| console.error( | ||
| error.message || error.error || t('Check configuration'), | ||
| ); | ||
| }); | ||
| } else { | ||
| setNativeFilterFieldValues(form, filterId, { | ||
| defaultValueQueriesData: response.result, | ||
| }); | ||
| forceUpdate(); | ||
| } | ||
| }); | ||
| }; |
There was a problem hiding this comment.
This logic is mostly copied over 1-1 from ./state.ts
junlincc
added
dashboard:native-filters
Codecov Report
@@ Coverage Diff @@
## master #14375 +/- ##
==========================================
- Coverage 76.89% 76.86% -0.03%
==========================================
Files 954 954
Lines 48197 48207 +10
Branches 6006 6008 +2
==========================================
- Hits 37062 37056 -6
- Misses 10939 10956 +17
+ Partials 196 195 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
amitmiran137
pushed a commit
that referenced
this pull request
Apr 28, 2021
) * feat(native-filters): add refresh button to default value picker * skip flaky test (cherry picked from commit 87a895c)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…che#14375) * feat(native-filters): add refresh button to default value picker * skip flaky test
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adds feature not automatically always populate the default value picker unless explicitly asked to do so.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
default_loader.mp4
TEST PLAN
ADDITIONAL INFORMATION