-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(native-filters): Auto apply changes in FiltersConfigModal #14461
Conversation
� Conflicts: � superset-frontend/src/dashboard/util/getPermissions.ts
@simcha90 is this PR only code refactoring? please include video in the PR if there's UI changes 🙏 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments - in general many great improvements here!
superset-frontend/src/filters/components/GroupBy/controlPanel.ts
Outdated
Show resolved
Hide resolved
...ashboard/components/nativeFilters/FiltersConfigModal/FiltersConfigForm/FiltersConfigForm.tsx
Outdated
Show resolved
Hide resolved
� Conflicts: � superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
Codecov Report
@@ Coverage Diff @@
## master #14461 +/- ##
==========================================
+ Coverage 77.06% 77.24% +0.17%
==========================================
Files 958 958
Lines 48242 48261 +19
Branches 6062 5649 -413
==========================================
+ Hits 37179 37277 +98
+ Misses 10862 10782 -80
- Partials 201 202 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
* fix:fix get permission function * feat: auto apply changes after save filters config modal * fix: repopulate default values * test: fix tests * test: fix tests * fix: fix CR notes * fix: fix CR notes (cherry picked from commit e8e838e)
My apologies, this was not intentional, I had missed this label 🙁 I'll look into adding a CI workflow to block merging if any restricted labels are present asap. |
…e#14461) * fix:fix get permission function * feat: auto apply changes after save filters config modal * fix: repopulate default values * test: fix tests * test: fix tests * fix: fix CR notes * fix: fix CR notes
…e#14461) * fix:fix get permission function * feat: auto apply changes after save filters config modal * fix: repopulate default values * test: fix tests * test: fix tests * fix: fix CR notes * fix: fix CR notes
…e#14461) * fix:fix get permission function * feat: auto apply changes after save filters config modal * fix: repopulate default values * test: fix tests * test: fix tests * fix: fix CR notes * fix: fix CR notes
SUMMARY
After user changes filters in FiltersConfig modal and clicks it automatically apply new changes to dashboard without need to click apply
Disable controls that affects dataMask in FiltersConfig modal until Default Value populates
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-05-06.at.9.20.12.mov
TEST PLAN
ADDITIONAL INFORMATION