Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(native-filters): Auto apply changes in FiltersConfigModal #14461

Merged
merged 14 commits into from
May 7, 2021

Conversation

simcha90
Copy link
Contributor

@simcha90 simcha90 commented May 4, 2021

SUMMARY

  1. After user changes filters in FiltersConfig modal and clicks it automatically apply new changes to dashboard without need to click apply

  2. Disable controls that affects dataMask in FiltersConfig modal until Default Value populates

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-05-06.at.9.20.12.mov

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc
Copy link
Member

junlincc commented May 5, 2021

@simcha90 is this PR only code refactoring? please include video in the PR if there's UI changes 🙏

@junlincc junlincc added the hold! On hold label May 5, 2021
@pull-request-size pull-request-size bot added size/L and removed size/S labels May 6, 2021
@simcha90 simcha90 changed the title refactor(native-filters): Auto apply changes in FiltersConfigModal feat(native-filters): Auto apply changes in FiltersConfigModal May 6, 2021
@simcha90
Copy link
Contributor Author

simcha90 commented May 6, 2021

@simcha90 is this PR only code refactoring? please include video in the PR if there's UI changes 🙏

done

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments - in general many great improvements here!

simcha90 added 2 commits May 6, 2021 11:24
� Conflicts:
�	superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #14461 (147d594) into master (68058b0) will increase coverage by 0.17%.
The diff coverage is 92.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14461      +/-   ##
==========================================
+ Coverage   77.06%   77.24%   +0.17%     
==========================================
  Files         958      958              
  Lines       48242    48261      +19     
  Branches     6062     5649     -413     
==========================================
+ Hits        37179    37277      +98     
+ Misses      10862    10782      -80     
- Partials      201      202       +1     
Flag Coverage Δ
javascript 72.38% <92.68%> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/filters/components/GroupBy/controlPanel.ts 100.00% <ø> (ø)
...tend/src/filters/components/Select/controlPanel.ts 63.63% <ø> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 70.17% <75.00%> (-0.07%) ⬇️
superset-frontend/src/dataMask/reducer.ts 70.83% <84.61%> (+2.54%) ⬆️
...et-frontend/src/dashboard/actions/nativeFilters.ts 80.00% <100.00%> (+26.15%) ⬆️
...tersConfigModal/FiltersConfigForm/ControlItems.tsx 100.00% <100.00%> (ø)
...mponents/nativeFilters/FiltersConfigModal/utils.ts 68.75% <100.00%> (+2.51%) ⬆️
superset-frontend/src/dataMask/actions.ts 78.57% <100.00%> (ø)
...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx 94.44% <0.00%> (+2.77%) ⬆️
...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx 100.00% <0.00%> (+3.84%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68058b0...147d594. Read the comment docs.

@villebro villebro merged commit e8e838e into apache:master May 7, 2021
amitmiran137 pushed a commit that referenced this pull request May 7, 2021
* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes

(cherry picked from commit e8e838e)
@junlincc junlincc added the dashboard:native-filters Related to the native filters of the Dashboard label May 12, 2021
@junlincc
Copy link
Member

@simcha90 @villebro Hi both, i would highly appreciate we look at PRs that are tagged "hold" together before merging.

@villebro
Copy link
Member

My apologies, this was not intentional, I had missed this label 🙁 I'll look into adding a CI workflow to block merging if any restricted labels are present asap.

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Sep 8, 2021
…e#14461)

* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes

(cherry picked from commit e8e838e)
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
…e#14461)

* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…e#14461)

* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…e#14461)

* fix:fix get permission function

* feat: auto apply changes after save filters config modal

* fix: repopulate default values

* test: fix tests

* test: fix tests

* fix: fix CR notes

* fix: fix CR notes
@mistercrunch mistercrunch added 🍒 1.2.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard:native-filters Related to the native filters of the Dashboard hold! On hold size/L v1.2 🍒 1.2.0 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants