Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): support different replicaCount #20883

Merged

Conversation

gforien
Copy link
Contributor

@gforien gforien commented Jul 27, 2022

SUMMARY

We want to configure a different replicaCount for supersetNode and supersetWorker deployments, as they do not undergo the same load.

The replicaCount should be configurable on a per component level instead of globally for the whole chart.

TESTING INSTRUCTIONS

Templating can be verified manually with helm template

  • helm lint
  • helm3 template superset-release .
  • Check that the new values are now required
❯ helm template superset-release .  --set supersetWorker.replicaCount=null --set supersetNode.replicaCount=null

Error: values don't meet the specifications of the schema(s) in the following chart(s):
superset:
- supersetWorker: replicaCount is required
- supersetNode: replicaCount is required

ADDITIONAL INFORMATION

@gforien gforien changed the title Feat/helm/add separate replicacount feat(helm): support separate replicaCount Jul 27, 2022
@gforien gforien changed the title feat(helm): support separate replicaCount feat(helm): support different replicaCount Jul 27, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@@ -28,7 +28,11 @@ metadata:
{{ toYaml .Values.supersetWorker.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
{{- if .Values.supersetWorker.replicaCount }}
replicas: {{ .Values.supersetWorker.replicaCount }}
{{- else }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just make a new value under supersetWorker and use it here (default of the current replicaCount)

Copy link
Contributor Author

@gforien gforien Jul 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok so I did

  • remove replicaCount in the values, in the schema, and in the array of required values
  • add supersetNode.replicaCount and supersetWorker.replicaCount in the values, in the schema, and in the array of required values
  • edit the "Running on Kubernetes" doc
  • bump version to 0.7.0

@@ -28,7 +28,11 @@ metadata:
{{ toYaml .Values.supersetNode.deploymentAnnotations | nindent 4 }}
{{- end }}
spec:
{{- if .Values.supersetNode.replicaCount }}
replicas: {{ .Values.supersetNode.replicaCount }}
{{- else }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above

@craig-rueda craig-rueda merged commit 8e0f16f into apache:master Aug 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants