feat: Tags ListView Page #24964

hughhhh · 2023-08-11T17:51:27Z

SUMMARY

Update Tags All Entities with new designs and add Edit Modal functionality + tons of bug fixes from QA internally

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

…ags-modal-api

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

kgabryje · 2023-09-12T08:03:14Z

superset-frontend/src/components/MetadataBar/MetadataBar.tsx

@@ -100,7 +100,6 @@ const StyledItem = styled.div<{
    }
    & .metadata-text {
      min-width: ${TEXT_MIN_WIDTH}px;
-      overflow: hidden;


Are you sure that removing overflow is needed here? I wonder if it won't break anything

looking at the metabar in the ui it didn't effect the styling from what i could see

It's required if the text in metadata bar is too long. 1 screenshot is with overflow: hidden, second is without

kgabryje · 2023-09-12T08:03:39Z

superset-frontend/src/components/PageHeaderWithActions/index.tsx

@@ -16,6 +16,7 @@
 * specific language governing permissions and limitations
 * under the License.
 */
+// @ts-nocheck


ts-nocheck here too

kgabryje · 2023-09-12T08:03:50Z

superset-frontend/src/features/tags/BulkTagModal.tsx

@@ -0,0 +1,98 @@
+// @ts-nocheck


kgabryje · 2023-09-12T08:04:01Z

superset-frontend/src/features/tags/TagModal.test.tsx

+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */


kgabryje · 2023-09-12T08:04:22Z

superset-frontend/src/pages/AllEntities/index.tsx

-import React, { useMemo } from 'react';
-import { ensureIsArray, styled, t } from '@superset-ui/core';
-import { StringParam, useQueryParam } from 'use-query-params';
+// @ts-nocheck


kgabryje · 2023-09-12T08:04:48Z

superset-frontend/src/pages/AllEntities/index.tsx

      </AllEntitiesNav>
-      <div className="select-control">
+      {/* <div className="select-control">


Commented code

kgabryje · 2023-09-12T08:05:04Z

superset-frontend/src/pages/Tags/index.tsx

@@ -16,6 +16,7 @@
 * specific language governing permissions and limitations
 * under the License.
 */


kgabryje · 2023-09-12T10:51:16Z

superset-frontend/src/features/tags/BulkTagModal.tsx

+        addSuccessToast(`Tagged ${selected.length} items`);
+      })
+      .catch(err => {
+        addDangerToast('Failed to tag items');


translation

kgabryje · 2023-09-12T10:51:21Z

superset-frontend/src/features/tags/BulkTagModal.tsx

+      },
+    })
+      .then(({ json = {} }) => {
+        addSuccessToast(`Tagged ${selected.length} items`);


translation

kgabryje · 2023-09-12T10:53:42Z

superset-frontend/src/features/tags/BulkTagModal.tsx

+      }
+    >
+      <>
+        <>{`You are adding tags to the ${selected.length} entities`}</>


translation

kgabryje · 2023-09-12T10:53:53Z

superset-frontend/src/features/tags/BulkTagModal.tsx

+          onHide={onHide}
+          // @ts-ignore
+          onChange={tags => setTags(tags)}
+          placeholder="Select Tags"


translation

kgabryje · 2023-09-12T10:55:31Z

superset-frontend/src/features/tags/TagModal.tsx

-interface TaggableResourceOption {
+const StyledModalBody = styled.div`
+  .ant-select-dropdown {
+    max-height: 100px;


theme.gridUnits

kgabryje · 2023-09-12T10:55:54Z

superset-frontend/src/features/tags/TagModal.tsx

-          value={description}
-        />
-        <Divider />
+      <FormLabel>{t('Tag Name')}</FormLabel>


'Tag name' name lowercase?

kgabryje · 2023-09-12T10:57:01Z

superset-frontend/src/pages/AllEntities/index.tsx

+    margin: 30px 0px;
+  }
+  .metadata-text {
+    height: 13px;


line-height: 1.4 instead of height

kgabryje · 2023-09-12T10:57:06Z

superset-frontend/src/pages/AllEntities/index.tsx

-  }`}
+  }
+  .entities {
+    margin: 30px 0px;


kgabryje · 2023-09-12T10:57:33Z

superset-frontend/src/pages/AllEntities/index.tsx

-  }`};
+  }
+  .header {
+    font-weight: 600;


font weight, font size and spacings from theme

kgabryje · 2023-09-12T10:57:48Z

superset-frontend/src/pages/AllEntities/index.tsx

+          setTag(tag);
+        },
+        (error: Response) => {
+          addDangerToast('Error Fetching Tagged Objects');


translation

kgabryje

LGTM

github-actions · 2023-09-12T12:48:40Z

Ephemeral environment shutdown and build artifacts deleted.

mistercrunch · 2023-09-13T17:39:08Z

Nice! excited to see this merged!

(cherry picked from commit 55ac01b)

hughhhh added 7 commits July 27, 2023 22:54

add create relationship dao + test

0e099cc

aadd create command for relationships

9ffd7c7

add api + test

6b75e34

create tags modal

98ecc81

save for now

c9ecff7

Merge branch 'master' of https://github.com/preset-io/superset into t…

93dc089

…ags-modal-api

remove unneeded migration

68d8ebf

pull-request-size bot added the size/L label Aug 11, 2023

hughhhh changed the title ~~fix: remove unused file (#24946)~~ feat: Tags Listview Page Aug 11, 2023

hughhhh changed the title ~~feat: Tags Listview Page~~ feat(draft): Tags Listview Page Aug 11, 2023

hughhhh added 7 commits August 11, 2023 19:05

Merge branch 'master' of https://github.com/preset-io/superset into t…

815fe05

…ags-modal-api

fix fe linting

b6da96f

update test

55d2e12

fix test

b474daf

added test

80d6090

fixed python test

423b069

fix linting

53c4590

pull-request-size bot added size/XXL and removed size/L labels Aug 18, 2023

hughhhh force-pushed the tags-listview branch from b159acc to 317dcff Compare August 18, 2023 14:12

hughhhh and others added 10 commits August 21, 2023 18:31

Update superset-frontend/src/features/tags/TagModal.tsx

da3a783

Co-authored-by: Elizabeth Thompson <eschutho@gmail.com>

refactory

18a81d1

update exception

417fae1

fix update test

c2e069d

ok

b7cfbc6

updating status codes

748d0cb

fix: remove unused file (apache#24946)

910656a

save

e30746d

save

4d68c24

saving

881712e

kgabryje reviewed Sep 12, 2023

View reviewed changes

superset-frontend/src/features/tags/BulkTagModal.tsx Outdated

@@ -0,0 +1,98 @@

// @ts-nocheck

Copy link

Member

kgabryje Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ts-nocheck

kgabryje reviewed Sep 12, 2023

View reviewed changes

hughhhh force-pushed the tags-listview branch from 944f17c to 50374d5 Compare September 12, 2023 10:51

kgabryje reviewed Sep 12, 2023

View reviewed changes

hughhhh force-pushed the tags-listview branch 3 times, most recently from d00603a to fdc94d1 Compare September 12, 2023 11:34

address kamil concernes

43eb5dd

hughhhh force-pushed the tags-listview branch from fdc94d1 to 43eb5dd Compare September 12, 2023 11:38

kgabryje approved these changes Sep 12, 2023

View reviewed changes

hughhhh merged commit 55ac01b into apache:master Sep 12, 2023
29 checks passed

hughhhh deleted the tags-listview branch September 12, 2023 12:48

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Sep 14, 2023

feat: Tags ListView Page (apache#24964)

0dd3d76

(cherry picked from commit 55ac01b)

jinghua-qa added the preset:2023.37 label Sep 14, 2023

eschutho pushed a commit to Superset-Community-Partners/superset that referenced this pull request Sep 21, 2023

feat: Tags ListView Page (apache#24964)

39ec061

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

feat: Tags ListView Page (apache#24964)

9852f28

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024

vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024

feat: Tags ListView Page (apache#24964)

f27976a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Tags ListView Page #24964

feat: Tags ListView Page #24964

hughhhh commented Aug 11, 2023 •

edited

Loading

kgabryje Sep 12, 2023

hughhhh Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje Sep 12, 2023

kgabryje left a comment

github-actions bot commented Sep 12, 2023

mistercrunch commented Sep 13, 2023

feat: Tags ListView Page #24964

feat: Tags ListView Page #24964

Conversation

hughhhh commented Aug 11, 2023 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kgabryje left a comment

Choose a reason for hiding this comment

github-actions bot commented Sep 12, 2023

mistercrunch commented Sep 13, 2023

hughhhh commented Aug 11, 2023 •

edited

Loading