-
Notifications
You must be signed in to change notification settings - Fork 14.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tags): Filter system tags from the tags list #26701
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26701 +/- ##
==========================================
+ Coverage 69.48% 69.50% +0.02%
==========================================
Files 1894 1895 +1
Lines 74138 74155 +17
Branches 8243 8243
==========================================
+ Hits 51515 51542 +27
+ Misses 20554 20538 -16
- Partials 2069 2075 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @Vitor-Avila!
SUMMARY
System tags used to be filtered from the Tags list (by filtering tags with
:
on their name). As a consequence, any user-created tag that included:
were not listed as well. #26324 fixed the issue by showing PRs with:
, which re-introduced system tags to the table.This PR adds a
custom_tag
boolean filter operator to the Tags API so that system tags are properly filtered out from the API response. Filtering these tags in the Client/Frontend side is not effective since your first page might be only system tags, so you would end up with 0 results in the table (and no option to paginate) + you would also end up with inconsistent counts per page.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
TAGGING_SYSTEM
is enabled.owner:{{user_id}}
) is not listed.ADDITIONAL INFORMATION
TAGGING_SYSTEM