Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dependencies): bump encodable to 0.7.8 #26903

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

rusackas
Copy link
Member

SUMMARY

Dependabot tried to go to 1.0, but it doesn't work as of 0.8.0 or higher without typescript headaches. This is the last version that seems to "just work"

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1f5ae74) 67.24% compared to head (c7c72c9) 66.94%.
Report is 65 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26903      +/-   ##
==========================================
- Coverage   67.24%   66.94%   -0.30%     
==========================================
  Files        1895     1900       +5     
  Lines       74248    76078    +1830     
  Branches     8257     8921     +664     
==========================================
+ Hits        49929    50934    +1005     
- Misses      22248    22970     +722     
- Partials     2071     2174     +103     
Flag Coverage Δ
javascript 56.78% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch
Copy link
Member

Note you can prevent dependabot from re-opening stuff here https://github.com/apache/superset/blob/master/.github/dependabot.yml#L4-L6

@rusackas
Copy link
Member Author

Note you can prevent dependabot from re-opening stuff here https://github.com/apache/superset/blob/master/.github/dependabot.yml#L4-L6

You can also do all this:

@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@john-bodley
Copy link
Member

@kristw any ideas how to upgrade this package?

@rusackas rusackas closed this Feb 1, 2024
@rusackas rusackas reopened this Feb 1, 2024
@rusackas rusackas merged commit fdff6d8 into master Feb 2, 2024
68 checks passed
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas rusackas deleted the bump-encodable branch April 16, 2024 16:51
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependencies:npm size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants