THRIFT-4251 Fix JDK Epoll Bug in Thrift of TThreadedSelectorServer model. #1313
Conversation
|
According to the documentation of the defect that triggered this (http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6670302), it indicates this only occurs in kernel 2.4 series, and if you move to kernel 2.6 this issue goes away. Given this is an operating system defect, I'm inclined to recommend we do not merge this and resolve it as won't fix, because it isn't a defect in Thrift or in Java, but rather in the operating system it is running on. |
|
My linux kernel is 3.10.0 when this bug occured. And I'm pretty sure that still trouble many people who dependence Thrift to implements theirs server program. Netty uses this approach to mask the underlying problem and why can't we. |
|
There are conflicting reports to what the root cause of this issue really is. I found: http://bugs.java.com/view_bug.do?bug_id=6693490 fixed in Java 7b55 Given you reproduced it under Java 8b131 then it sounds like it would be a different issue to what's already been reported, or a regression in one of them. Folks seem to think this issue was resolved. I actually found a number of projects that implemented their own solution, but they were all slightly different. Have you looked into reopening 6670302 with a sample program that recreates it under Java 8b131? Or, does the sample app used in that defect reproduce on your system possibly? |
|
I found a report maybe more relevant with this issue. |
|
However, as with all the other issues, they were already resolved, so the fact you are still seeing this with a recent kernel and java version means there's still a bug that needs to be fixed somewhere. There shouldn't be a workaround in every Java program that uses a Selector(). I would still encourage you to come up with a simple example that demonstrates it without Thrift involved and report it upstream. |
|
It's not elegant way to rebuild Selector in every Java program, but it's a effective way to fix this bug. And so many year passed it not really fixed in JDK or kernel. This is one reason for some Frameworks implemented this solution. After all, the consequences of this bug are too serious. |
|
http://bugs.java.com/bugdatabase/view_bug.do?bug_id=6403933 |
|
I'd like additional feedback from folks who use Thrift with Java on this. It seems like the wrong place to fix the issue, but it sounds like many projects are implementing their own fix for it. I've never seen it happen. |
|
So I asked on the mailing list and it's been crickets, so I'm going to merge this. It passed all the tests. |
|
MY english is poor. could you please explain what is the it's been crickets mean ? thank you very much! |
|
It means nobody replied to my requests for comments, so I assumed nobody
has an issue or nobody cares; whatever the case, I committed it to the
project. :)
…On Thu, Sep 21, 2017 at 9:33 PM, xiaohu-zhang ***@***.***> wrote:
MY english is poor. could you please explain what is the it's been
crickets mean ? thank you very much!
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1313 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ALOdbQESIjeimaSz2AGiRW8KU8nn7Zzhks5skw5ngaJpZM4OiH7s>
.
|
…odel. Client: Java This closes apache#1313
|
Thank you ! honestly speaking , netty and lots of framework implementing this fix. I also doubt |
…odel. Client: Java This closes apache#1313
Such as the title. More information see : https://issues.apache.org/jira/browse/THRIFT-4251