rewrite the endian conversion to fix a big-endian host #2754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This might need a Jira ticket, but I don't have a Jira account. I will try to ask for a Jira account, but I'm not sure how.)
Client: py
Change htolell(dub) to htolell(transfer.t) in compact.h, because the conversion takes a long long, not a double. This matters on a big-endian host, where the conversion must swap bytes.
The big-endian letohll(n) failed because ntohl(n) is just n, doesn't swap n. Rewrite ntohll(n) and letohll(n) to use the same code with both big-endian and little-endian hosts. Expect the compiler to optimize away one of ntohll(n) or letohll(n) when it doesn't swap n.
[skip ci]
anywhere in the commit message to free up build resources.