Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite the endian conversion to fix a big-endian host #2754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kernigh
Copy link

@kernigh kernigh commented Feb 7, 2023

(This might need a Jira ticket, but I don't have a Jira account. I will try to ask for a Jira account, but I'm not sure how.)

Client: py

Change htolell(dub) to htolell(transfer.t) in compact.h, because the conversion takes a long long, not a double. This matters on a big-endian host, where the conversion must swap bytes.

The big-endian letohll(n) failed because ntohl(n) is just n, doesn't swap n. Rewrite ntohll(n) and letohll(n) to use the same code with both big-endian and little-endian hosts. Expect the compiler to optimize away one of ntohll(n) or letohll(n) when it doesn't swap n.

  • Did you create an Apache Jira ticket? (not required for trivial changes)
  • If a ticket exists: Does your pull request title follow the pattern "THRIFT-NNNN: describe my issue"?
  • Did you squash your changes to a single commit? (not required, but preferred)
  • Did you do your best to avoid breaking changes? If one was needed, did you label the Jira ticket with "Breaking-Change"?
  • If your change does not involve any code, include [skip ci] anywhere in the commit message to free up build resources.

Client: py

Change htolell(dub) to htolell(transfer.t) in compact.h, because the
conversion takes a long long, not a double.  This matters on a
big-endian host, where the conversion must swap bytes.

The big-endian letohll(n) failed because ntohl(n) is just n, doesn't
swap n.  Rewrite ntohll(n) and letohll(n) to use the same code with
both big-endian and little-endian hosts.  Expect the compiler to
optimize away one of ntohll(n) or letohll(n) when it doesn't swap n.
@Jens-G Jens-G added the python label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants