UnitTest may fail when the platform does not support handling localization-related operations #2846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the situation that the locale function encountered a situation that the platform did not support when handling localization-related operations, resulting in test failure
Jens-G
requested changes
Aug 22, 2023
| BOOST_CHECK_EQUAL(to_string(1000000), "1000000"); | ||
| BOOST_CHECK_EQUAL(to_string(1000000), "1000000"); | ||
| } catch (const std::runtime_error& e) { | ||
|
|
There was a problem hiding this comment.
Empty catch-all clauses are triggering some sort of "Are you sure?" reflex. Especially if the patch is called a fix. I would rather label it as "curing a symptom". Can we have at least a comment explaining why this is the optimal way to handle it?
| BOOST_CHECK_EQUAL(to_string(1.5f), "1.5"); | ||
| BOOST_CHECK_EQUAL(to_string(1.5L), "1.5"); | ||
| } catch (const std::runtime_error& e) { | ||
|
|
Jens-G
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the situation that the locale function encountered a situation that the platform did not support when handling localization-related operations, resulting in test failure