Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

THRIFT-5766: Replace std::endl with "\n" #2943

Closed
wants to merge 9 commits into from
Closed

THRIFT-5766: Replace std::endl with "\n" #2943

wants to merge 9 commits into from

Commits on Mar 23, 2024

  1. Replace usage of endl with '\n' directly 

    - Moves away from the bad habid of using endl which is known to flush
- Remove references to endl and replace with line break
    @CJCombrink
    CJCombrink committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    ac117f7 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. Merge branch 'master' into feature/remove_endl

    @Jens-G
    Jens-G authored Apr 4, 2024
    Configuration menu
    Copy the full SHA
    8619174 View commit details
    Browse the repository at this point in the history

Commits on Apr 11, 2024

  1. Merge branch 'master' into feature/remove_endl

    @Jens-G
    Jens-G authored Apr 11, 2024
    Configuration menu
    Copy the full SHA
    2091f72 View commit details
    Browse the repository at this point in the history

  2. Remove br 

    - Fixed a few places that were then literal + literal to ensure at least one is a std::string
- PR Review feedback
    @CJCombrink
    CJCombrink committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    8b51d05 View commit details
    Browse the repository at this point in the history

  3. Revert overflow on line 

    - PR feedback
    @CJCombrink
    CJCombrink committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    6e7ac8c View commit details
    Browse the repository at this point in the history

  4. Keep consistent with the spirit of the PR and the surrounding code 

    - Braced init is a habit
    @CJCombrink
    CJCombrink committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    ca8ebf5 View commit details
    Browse the repository at this point in the history

  5. Fix cerr as well 

    - PR Review feedback
- Initially skipped cerr but after some reading, cerr will flush after every << thus endl can also be avoided.
    @CJCombrink
    CJCombrink committed Apr 11, 2024
    Configuration menu
    Copy the full SHA
    c5800a2 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. Fixed error 

    - Picked up in review
    @CJCombrink
    CJCombrink committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    e2224de View commit details
    Browse the repository at this point in the history

  2. Fix merge error

    @CJCombrink
    CJCombrink committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    abffc03 View commit details
    Browse the repository at this point in the history