Skip to content

TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers #1031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 25, 2019
Merged

TINKERPOP-2127: Add Python TraversalMetrics/Metrics deserializers #1031

merged 2 commits into from
Jan 25, 2019

Conversation

aboudreault
Copy link
Contributor

We only deserialize those types as a dict. Also, this should probably target tp34 when created.

@aboudreault aboudreault force-pushed the tinkerpop-2127 branch 2 times, most recently from 787cb5e to bb64220 Compare January 9, 2019 13:36
@aboudreault
Copy link
Contributor Author

@spmallette to review

@aboudreault
Copy link
Contributor Author

This is ready for review. explain() doesn't exist in gremlinpython, so g:TraversalExplanation hasn't been added. I've created https://issues.apache.org/jira/browse/TINKERPOP-2128 for the purpose of the missing explain() and check back when it's done.

@spmallette
Copy link
Contributor

Any reason not to target the tp33 branch with this? g:TraversalMetrics is on the 3.3.x line as well i think.

@aboudreault aboudreault changed the base branch from master to tp33 January 11, 2019 18:47
@aboudreault aboudreault changed the base branch from tp33 to master January 11, 2019 18:48
@aboudreault
Copy link
Contributor Author

I think tp33 doesn't have graphson3 so I will need to do another PR

@spmallette
Copy link
Contributor

GraphSON 3 was initially released on the 3.3.x line:

http://tinkerpop.apache.org/docs/3.3.5/dev/io/#_traversalmetrics_2

@aboudreault
Copy link
Contributor Author

ah. I will update.

@aboudreault aboudreault changed the base branch from master to tp33 January 15, 2019 15:09
@aboudreault
Copy link
Contributor Author

Rebased for tp33

@spmallette
Copy link
Contributor

VOTE +1

@jorgebay
Copy link
Contributor

VOTE +1 :shipit:

@spmallette spmallette merged commit b565908 into apache:tp33 Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aboudreault @spmallette @jorgebay