TINKERPOP-2134 Bump to Groovy 2.5.6 #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Building...
VOTE +1 |
spmallette
force-pushed
the
TINKERPOP-2134
branch
from
e181a43
to
b35612c
Compare
|
VOTE +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/TINKERPOP-2134
I bumped this a long time ago - actually started with 2.5.5, but that version seemed to do something unstable to spark for some reason?? before i had time to really investigate 2.5.6 came out so I figured I'd just try that. The spark issue stopped but then there was other build problems with docker so I laid off issuing the PR again. After a number of investigations/fixes around the docker failures which seemed unrelated to this Groovy change, I've finally gotten some consecutive clean docker runs. Still not completely sure that Groovy ever had anything to do with the problem. I'd appreciate if reviewers could do some docker runs themselves to see what their environments show, but other than that, I'm going to go with:
All tests pass with
docker/build.sh -t -n -iVOTE +1