refactor ResultSet.One() to handle nil result #1653
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L0Lmaker
reviewed
May 12, 2022
Codecov Report
@@ Coverage Diff @@
## 3.5-dev #1653 +/- ##
===========================================
- Coverage 66.89% 66.85% -0.04%
===========================================
Files 23 23
Lines 3510 3515 +5
===========================================
+ Hits 2348 2350 +2
- Misses 976 978 +2
- Partials 186 187 +1
Continue to review full report at Codecov.
|
simonz-bq
reviewed
May 12, 2022
L0Lmaker
approved these changes
May 12, 2022
|
VOTE+1 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor ResultSet.One() to handle nil result