Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite /deliveryservice_user to Go #3836

Closed
1 task
ocket8888 opened this issue Aug 6, 2019 · 3 comments · Fixed by #4369
Closed
1 task

Rewrite /deliveryservice_user to Go #3836

ocket8888 opened this issue Aug 6, 2019 · 3 comments · Fixed by #4369
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Milestone

Comments

@ocket8888
Copy link
Contributor

ocket8888 commented Aug 6, 2019

I'm submitting an ...

improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Documentation (possibly)
  • Traffic Ops

Current behavior:

/deliveryservice_user is handled by Perl

Expected / new behavior:

/deliveryservice_user should be handled by Go.

Minimum API Version

1.1

Request Methods

  • POST

Minimal reproduction of the problem with instructions:

N/A

Anything Else

PR in progress: #2457 . Progress to completion is unknown

@ocket8888 ocket8888 added Traffic Ops related to Traffic Ops tech debt rework due to choosing easy/limited solution labels Aug 6, 2019
@ocket8888 ocket8888 changed the title Rewrite /deliveryservice_user /deliveryservice_user to Go Rewrite /deliveryservice_user to Go Aug 6, 2019
@ocket8888 ocket8888 added this to the Go Rewrite milestone Aug 13, 2019
@mitchell852
Copy link
Member

mitchell852 commented Sep 11, 2019

i think this should be deprecated (not rewritten to Go and a deprecation notice added to the perl response) as assigning delivery services to a user has no effect in our current system due to the introduction of tenancy.

@ocket8888
Copy link
Contributor Author

the decision to either deprecate and/or rewrite the endpoint can't be made here, but once the decision is made this issue can be closed (if appropriate)

@rawlinp
Copy link
Contributor

rawlinp commented Sep 13, 2019

+1 on deprecation. If it even does have an affect anywhere, the code should be fixed to where tenant is used over delivery service users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
3 participants