Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress "Updated primary origin" changelog entry if DS orgServerFqdn is unchanged #5335

Closed
rawlinp opened this issue Nov 25, 2020 · 1 comment · Fixed by #5410
Closed

Suppress "Updated primary origin" changelog entry if DS orgServerFqdn is unchanged #5335

rawlinp opened this issue Nov 25, 2020 · 1 comment · Fixed by #5410
Assignees
@srijeet0406
Labels
improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Nov 25, 2020

I'm submitting a ...

  • improvement request (usability, performance, tech debt, etc.)

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

When updating a delivery service, a changelog entry is created that says "DS: foo, ID: 442, ACTION: Updated primary origin: foo" even if the DS's orgServerFqdn wasn't changed.

New behavior:

The aforementioned changelog entry should only be created if the DS's orgServerFqdn is changed.

Minimal reproduction of the problem with instructions:

Create a delivery service then make any update it. See the changelog entries.
@rawlinp rawlinp added Traffic Ops related to Traffic Ops improvement The functionality exists but it could be improved in some way. labels Nov 25, 2020
@rawlinp rawlinp mentioned this issue Nov 25, 2020
Closed
@srijeet0406
Copy link
Contributor

I can take this one

@srijeet0406 srijeet0406 mentioned this issue Jan 7, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srijeet0406 srijeet0406

Labels
improvement The functionality exists but it could be improved in some way. Traffic Ops related to Traffic Ops
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Dont show changelog msg for primary origin if it wasn't updated srijeet0406/trafficcontrol
2 participants
@rawlinp @srijeet0406