PUT /api/3.0/deliveryservices/{id} with changed cdn returns 403 forbidden

[mitchell852]

I'm submitting a ...

• bug report

Traffic Control components affected ...

• Traffic Ops
• Traffic Portal

Current behavior:

Changing the CDN for a delivery service returns a 403 with

{"alerts":[{"text":"Forbidden","level":"error"}]}

403s are for operations that fail role or tenancy check.

New behavior:

This needs to be a 400 Bad Request instead with a message like:

{"alerts":[{"text":"Delivery service CDN is immutable","level":"error"}]}

Minimal reproduction of the problem with instructions:

Navigate to a DS in TP and change the CDN value. Save.

Anything else:

If the intent is to make CDN immutable on a DS, the cdn field of an existing DS should be disabled as well to prevent the user from changing it.

[mitchell852]

@shamrickus or @srijeet0406 - i cant remember if one of you did the api work on this or not...

[srijeet0406]

I think that might have been Steve. Its in the getOlddetails function I believe.

[mitchell852]

oh, ok, this was changed in #5083 - can you make it return a 400 bad request instead of 403 (with an error message that explains why they can't do that) @shamrickus when ds.cdn or ds.routingName change is attempted?

[rimashah25]

I can take this one.

[srijeet0406]

I think @shamrickus is working on this one, not a 100% sure