Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUT /users/:id sets tm_user.registration_sent (date) to null #5445

Closed
mitchell852 opened this issue Jan 15, 2021 · 1 comment · Fixed by #5452
Closed

PUT /users/:id sets tm_user.registration_sent (date) to null #5445

mitchell852 opened this issue Jan 15, 2021 · 1 comment · Fixed by #5452
Assignees
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops

Comments

@mitchell852
Copy link
Member

mitchell852 commented Jan 15, 2021

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

PUT /users/:id sets tm_user.registration_sent (date) to null

Expected behavior:

PUT /users/:id should NOT touch tm_user.registration_sent (date) in any way. if it has a value, leave it. if it has no value, leave it.

tm_user.registration_sent is set if a user is created via POST users/register and should never be nulled once it is set. it can, however, be updated if POST users/register is called again with the same email BUT it should never be nulled.

Minimal reproduction of the problem with instructions:

  • Create a user via POST users/register and provide email, tenant and role
  • check the database for the newly created user. see that registration_sent is set to current date/time
  • note the id of the newly created user
  • update the newly created user via PUT /user/:id and notice that registration_sent is set to null. this is wrong.
@mitchell852 mitchell852 added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Jan 15, 2021
@rimashah25
Copy link
Contributor

I can take this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants