Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic Ops HTTP response write errors are ignored #5954

Closed
rawlinp opened this issue Jun 17, 2021 · 0 comments · Fixed by #5984
Closed

Traffic Ops HTTP response write errors are ignored #5954

rawlinp opened this issue Jun 17, 2021 · 0 comments · Fixed by #5984
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops

Comments

@rawlinp
Copy link
Contributor

rawlinp commented Jun 17, 2021

I'm submitting a ...

  • bug report

Traffic Control components affected ...

  • Traffic Ops

Current behavior:

Most of the functions that write HTTP responses in TO ignore write errors, like this one for example. This means that if there are any errors writing HTTP responses (due to e.g. hitting timeouts), we are mostly blind to them currently.

Expected behavior:

TO should log warnings if any errors occur when writing HTTP responses.

Minimal reproduction of the problem with instructions:

Since the current behavior is invisible, you're just going to have to look at the code and trust me on this.

@rawlinp rawlinp added bug something isn't working as intended Traffic Ops related to Traffic Ops labels Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something isn't working as intended Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant