Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Parser error with nn.dense #6470

Closed
gussmith23 opened this issue Sep 14, 2020 · 4 comments
Closed

[BUG] Parser error with nn.dense #6470

gussmith23 opened this issue Sep 14, 2020 · 4 comments

Comments

@gussmith23
Copy link
Contributor

Parsing a Relay program which uses nn.dense seems to be finicky! I might be doing something wrong here, let me know!

A minimum working example:

import tvm
from tvm import relay
from tvm.relay.testing.mobilenet import get_workload

x = relay.var('x', shape = (3,))
y = relay.var('y', shape = (3,3))
prog = relay.nn.dense(x, y)
function = relay.Function([x, y], prog)
module = tvm.IRModule.from_expr(function)

print(module.astext())

tvm.parser.fromtext(module.astext())

# if we remove the "None" that is causing the error, we get a different error:
tvm.parser.fromtext(
'''
#[version = "0.0.5"]
def @main(%x: Tensor[(3), float32], %y: Tensor[(3, 3), float32]) -> Tensor[(3), float32] {
  nn.dense(%x, %y) /* ty=Tensor[(3), float32] */
}
'''
    )
@jroesch
Copy link
Member

jroesch commented Sep 14, 2020

It could be a bug, I've fixed a ton of bugs on #6274, I'll try to add a regression there.

gussmith23 added a commit to gussmith23/glenside that referenced this issue Sep 15, 2020
nn.dense parsing is broken in Relay at the moment. See:
apache/tvm#6470
@tqchen tqchen closed this as completed Nov 1, 2020
@tqchen tqchen reopened this Nov 1, 2020
@tqchen
Copy link
Member

tqchen commented Nov 1, 2020

@gussmith23 please check if the problem persists in main

@gussmith23
Copy link
Contributor Author

Looks like it's gone!

@gussmith23
Copy link
Contributor Author

I'm getting another error in the Rust bindings now. Will open a different issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants