[TOPI] Add C++ implementation of elementwise operators #1306

nishi-t · 2018-06-21T05:31:54Z

This PR adds c++ implementation of elementwise operators:

elemwise_sum
full
full_like
~~less~~
~~greter~~

PariksheetPinjari909

Redirect the python ops to c++ ops, keep the doc strings of python ops

PariksheetPinjari909 · 2018-06-21T06:16:55Z

topi/include/topi/elemwise.h

+                      const Tensor& rhs,
+                      Type out_type,
+                      std::string name = "tensor",
+                      std::string tag = kElementWise) {


Indentation

PariksheetPinjari909 · 2018-06-21T06:19:19Z

topi/include/topi/elemwise.h

+* \param rhs The input tensor
+* \param out_type The type of output
+*
+* \return A Tensor filled with fill_value


add correct doc string

PariksheetPinjari909 · 2018-06-21T06:19:50Z

topi/include/topi/elemwise.h

+* \param rhs The input tensor
+* \param out_type The type of output
+*
+* \return A Tensor filled with fill_value


add correct doc string

srkreddy1238 · 2018-06-21T06:16:35Z

topi/include/topi/elemwise.h

+* \return A Tensor whose op member is the sum operation
+*/
+inline Tensor elemwise_sum(const Array<Tensor>& xs,
+                           int num_args,


What is the significance of num_args?

I add num_args as argument correspond to python implementation, but it is not used in there too. If not necessary, I'll remove it from arguments both cpp and python. Would you comment on this?
\cc @tqchen

Can be remove safely

Ok, thanks!

srkreddy1238 · 2018-06-21T06:19:57Z

topi/include/topi/elemwise.h

+                   Expr fill_value,
+                   std::string name = "tensor",
+                   std::string tag = kElementWise) {
+  Expr ev = lossless_cast(dtype, fill_value);


It's possible that lossless_cast could return an undefined Expr.

Could raise an appropriate error here to user !

srkreddy1238 · 2018-06-21T06:20:05Z

topi/include/topi/elemwise.h

+                        Expr fill_value,
+                        std::string name = "tensor",
+                        std::string tag = kElementWise) {
+  Expr ev = lossless_cast(x->dtype, fill_value);


It's possible that lossless_cast could return an undefined Expr.

Could raise an appropriate error here to user !

srkreddy1238 · 2018-06-21T06:21:17Z

topi/src/topi.cc

@@ -174,6 +174,31 @@ TVM_REGISTER_GLOBAL("topi.cast")
  *rv = cast(args[0], args[1]);
  });

+TVM_REGISTER_GLOBAL("topi.elemwise_sum")
+.set_body([](TVMArgs args, TVMRetValue *rv) {
+  *rv = elemwise_sum(args[0], args[1]);


Corresponding to above comment, number or args can be obtained inside topi by size().

nishi-t · 2018-06-21T12:24:17Z

@srkreddy1238 @PariksheetPinjari909 Thank you for your review. I'm acting on your comments.

nishi-t · 2018-06-22T08:56:28Z

@PariksheetPinjari909 @srkreddy1238 Plase review again.

srkreddy1238 · 2018-06-22T09:37:29Z

topi/include/topi/elemwise.h

+* \return A Tensor filled with fill_value
+*/
+inline Tensor full_like(const Tensor& x,
+                        Expr fill_value,


const Expr fill_value

srkreddy1238 · 2018-06-22T09:38:11Z

topi/include/topi/elemwise.h

+*/
+inline Tensor full(const Array<Expr>& shape,
+                   Type dtype,
+                   Expr fill_value,


const Expr fill_value

srkreddy1238 · 2018-06-22T09:40:23Z

topi/tests/python_cpp/test_topi_tensor.py

+import tvm
+import topi
+
+def verify_elemwise_sum(num_args, dtype):


Remove num_args here as well.

I use num_args here to generate test data for doing various element_wise tests.

srkreddy1238 · 2018-06-22T09:43:51Z

topi/tests/python_cpp/test_topi_tensor.py

+        np_out = np.sum(np.array(np_nd), axis=0)
+        np.testing.assert_allclose(out.asnumpy(), np_out, rtol=1e-5)
+
+    for device in ["llvm"]:


Specific reason for only llvm ?

srkreddy1238 · 2018-06-22T09:45:37Z

@nishi-t
other than these comments LGTM.

PariksheetPinjari909 · 2018-06-22T09:24:05Z

topi/include/topi/elemwise.h

+* \brief Creates an operation that fill a tensor with fill_value
+*
+* \param shape The shape of a tensor
+* \param dtype The number of arguments


add correct doc string for dtype

PariksheetPinjari909 · 2018-06-22T09:24:40Z

topi/include/topi/elemwise.h

+* \param name The name of the operation
+* \param tag The tag to mark the operation
+*
+* \return A Tensor filled with fill_value


add correct doc string

PariksheetPinjari909 · 2018-06-22T09:24:57Z

topi/include/topi/elemwise.h

+* \param name The name of the operation
+* \param tag The tag to mark the operation
+*
+* \return A Tensor filled with fill_value


add correct doc string

PariksheetPinjari909 · 2018-06-22T09:27:06Z

topi/tests/python_cpp/test_topi_tensor.py

+
+
+if __name__ == "__main__":
+    test_elemwise_sum()


call test_full and test_comparator

PariksheetPinjari909 · 2018-06-22T09:33:05Z

topi/include/topi/elemwise.h

+*
+* \return A Tensor filled with fill_value
+*/
+inline Tensor full(const Array<Expr>& shape,


why is the name full. It's operation is to fill the tensor with value fill_value. Shouldn't the name be 'fill'?
@tqchen python op also has the name 'full'. Can you clarify here.

mxnet and numpy use full as operation name, but tensorflow use fill. maybe it's a matter of taste. I'll follow community's direction.

https://docs.scipy.org/doc/numpy-1.14.0/reference/generated/numpy.full.html

https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.full

https://www.tensorflow.org/api_docs/python/tf/fill

nishi-t · 2018-06-22T10:10:44Z

@srkreddy1238 @PariksheetPinjari909 thanks a lot. I'll fix it according to your comments.

tqchen · 2018-06-22T23:52:21Z

please rebase against master, greater and less are added in #1321 and supported as broadcast ops

tqchen · 2018-06-26T03:38:38Z

@nishi-t please ping the reviewers again once you have updates

tqchen · 2018-06-26T17:17:24Z

@PariksheetPinjari909 @srkreddy1238 can you do another round of review? please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

srkreddy1238

@nishi-t thanks.

Good to go now.

tqchen · 2018-06-27T01:40:49Z

Thanks all the reviewers, this is now merged!

nishi-t changed the title ~~Add C++ implementation of elementwise operators~~ [TOPI] Add C++ implementation of elementwise operators Jun 21, 2018

PariksheetPinjari909 suggested changes Jun 21, 2018

View reviewed changes

srkreddy1238 requested changes Jun 21, 2018

View reviewed changes

srkreddy1238 requested changes Jun 22, 2018

View reviewed changes

PariksheetPinjari909 suggested changes Jun 22, 2018

View reviewed changes

Tatsuya.Nishiyama added 5 commits June 23, 2018 16:49

Add cpp implementations of elemwise operators

118001a

Fix doc and redirect ops.

ed53405

Add raising error message when lossless_cast fail

6e6ae87

remove num_args from elemwise_sum

9da3a0a

fix calling elemwise_sum in nnvm

623911e

nishi-t force-pushed the elemwise_op_cpp branch from fae85d3 to 9d62be1 Compare June 23, 2018 08:23

revet against master

e34a3d2

nishi-t force-pushed the elemwise_op_cpp branch from 9d62be1 to e34a3d2 Compare June 25, 2018 02:38

Change scheduling of elemwise operation's test

1892cab

fix test

7dd6409

srkreddy1238 approved these changes Jun 26, 2018

View reviewed changes

tqchen approved these changes Jun 27, 2018

View reviewed changes

tqchen merged commit c6feab2 into apache:master Jun 27, 2018

tqchen added the status: accepted label Jun 27, 2018

tqchen pushed a commit to tqchen/tvm that referenced this pull request Jul 6, 2018

[TOPI] Add C++ implementation of elementwise operators (apache#1306)

39506f2

mnuyens pushed a commit to mnuyens/tvm that referenced this pull request Jul 10, 2018

[TOPI] Add C++ implementation of elementwise operators (apache#1306)

5068178

sergei-mironov pushed a commit to sergei-mironov/tvm that referenced this pull request Aug 8, 2018

[TOPI] Add C++ implementation of elementwise operators (apache#1306)

100563e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TOPI] Add C++ implementation of elementwise operators #1306

[TOPI] Add C++ implementation of elementwise operators #1306

nishi-t commented Jun 21, 2018 •

edited

Loading

PariksheetPinjari909 left a comment

PariksheetPinjari909 Jun 21, 2018

PariksheetPinjari909 Jun 21, 2018

PariksheetPinjari909 Jun 21, 2018

srkreddy1238 Jun 21, 2018

nishi-t Jun 21, 2018 •

edited

Loading

tqchen Jun 21, 2018

nishi-t Jun 22, 2018

srkreddy1238 Jun 21, 2018

srkreddy1238 Jun 21, 2018

srkreddy1238 Jun 21, 2018

nishi-t commented Jun 21, 2018 •

edited

Loading

nishi-t commented Jun 22, 2018

srkreddy1238 Jun 22, 2018

srkreddy1238 Jun 22, 2018

srkreddy1238 Jun 22, 2018

nishi-t Jun 23, 2018

srkreddy1238 Jun 22, 2018

srkreddy1238 commented Jun 22, 2018

PariksheetPinjari909 Jun 22, 2018

PariksheetPinjari909 Jun 22, 2018

PariksheetPinjari909 Jun 22, 2018

PariksheetPinjari909 Jun 22, 2018

PariksheetPinjari909 Jun 22, 2018

nishi-t Jun 23, 2018

PariksheetPinjari909 Jun 25, 2018

nishi-t commented Jun 22, 2018

tqchen commented Jun 22, 2018

tqchen commented Jun 26, 2018

tqchen commented Jun 26, 2018

srkreddy1238 left a comment

tqchen commented Jun 27, 2018

[TOPI] Add C++ implementation of elementwise operators #1306

[TOPI] Add C++ implementation of elementwise operators #1306

Conversation

nishi-t commented Jun 21, 2018 • edited Loading

PariksheetPinjari909 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishi-t Jun 21, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishi-t commented Jun 21, 2018 • edited Loading

nishi-t commented Jun 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

srkreddy1238 commented Jun 22, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nishi-t commented Jun 22, 2018

tqchen commented Jun 22, 2018

tqchen commented Jun 26, 2018

tqchen commented Jun 26, 2018

srkreddy1238 left a comment

Choose a reason for hiding this comment

tqchen commented Jun 27, 2018

nishi-t commented Jun 21, 2018 •

edited

Loading

nishi-t Jun 21, 2018 •

edited

Loading

nishi-t commented Jun 21, 2018 •

edited

Loading