[TOPI] Numpy consistency: always broadcast binary op. #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmoreau89
reviewed
Jun 22, 2018
topi/src/topi.cc
Outdated
| @@ -149,10 +148,11 @@ TVM_REGISTER_GLOBAL("topi.negative") | |||
| *rv = negative(args[0]); | |||
| }); | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
@tqchen is there any reason why this is commented out instead of deleted?
tmoreau89
reviewed
Jun 22, 2018
| verify_broadcast_binary_ele((32,), (64, 32), typ="maximum") | ||
| verify_broadcast_binary_ele((1, 2, 2, 1, 32), (64, 32), typ="minimum") | ||
| verify_broadcast_binary_ele( | ||
| (5, 2, 3), (2, 1), topi.add, np.add) |
tmoreau89
reviewed
Jun 22, 2018
| verify_broadcast_binary_ele( | ||
| (5, 2, 3), (), topi.subtract, np.subtract) | ||
| verify_broadcast_binary_ele( | ||
| (5, 2, 3), None, topi.subtract, np.subtract) |
tmoreau89
reviewed
Jun 22, 2018
tqchen
changed the title
tqchen
force-pushed
the
master
branch
2 times, most recently
from
bff71d0
to
cd507b1
Compare
|
@tmoreau89 you might need to update downstream call to broadcast_ops as they are renamed |
tqchen
added a commit
to tqchen/tvm
that referenced
this pull request
Jul 6, 2018
mnuyens
pushed a commit
to mnuyens/tvm
that referenced
this pull request
Jul 10, 2018
sergei-mironov
pushed a commit
to sergei-mironov/tvm
that referenced
this pull request
Aug 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of Operators