Use adapter.info when available instead of requestAdapterInfo #17051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neet-Nestor
suggested changes
May 31, 2024
There was a problem hiding this comment.
@beaufortfrancois There's a build issue as adapter.info is not available in the outdated @webgpu/types. Could you please update the PR by run npm install @webgpu/types in /web?
tqchen
approved these changes
Jun 1, 2024
|
@tqchen Can you redeploy https://chat.webllm.ai/ with this fix? |
|
@beaufortfrancois Deploying. Should be done in minutes. If you have any issue with the chat app specifically, feel free to raise at https://github.com/mlc-ai/web-llm-chat/issues too. |
|
Thank you @Neet-Nestor. https://chat.webllm.ai/ works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on gpuweb/gpuweb#4662, this PR uses synchronous
adapter.infowhen available instead of the deprecatedrequestAdapterInfo()method.