WICKET-7152: HTTP-StatusCodes 307 and 308 now supported by RedirectRequestHandler #1133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-g
reviewed
Mar 27, 2025
wicket-request/pom.xml
Outdated
| <dependency> | ||
| <groupId>org.junit.jupiter</groupId> | ||
| <artifactId>junit-jupiter-params</artifactId> | ||
| <scope>test</scope> |
There was a problem hiding this comment.
The scope should be defined in the dependencyManagement section in the parent pom.
There was a problem hiding this comment.
Resolved. Removed scope (inherit scope from dependencyManagement of parent-pom)
| } | ||
| // Mode.AUTO | ||
| else if (status == HttpServletResponse.SC_MOVED_TEMPORARILY) | ||
| else if (status == HttpServletResponse.SC_FOUND) |
There was a problem hiding this comment.
Hi, SC_FOUND is the same code as SC_MOVED_TEMPORARILY (302). There is a comment in the source file of HttpServletResponse concerning SC_MOVED_TEMPORARILY: "SC_FOUND is now the preferred definition." That's the reason why I changed it.
martin-g
approved these changes
Apr 1, 2025
bitstorm
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/WICKET-7152