New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ZEPPELIN-1554] Update jekyll version to 3.2.1 with its dependencies and fix document… #1577
Conversation
… style as kramdown.
@AhyoungRyu Can I ask you to allow me to change JIRA ZEPPELIN-1554 assignee and progress? In case of self proposal and PR like this, It would be great to use JIRA as contributor access :) |
@yoonjs2 just added your name to contributor role |
@AhyoungRyu @minahlee Thanks! Let me know if patch needs any change :) |
@yoonjs2 Seems "Prepare L10N support on documentation" is unchecked in the PR description. Is it done now? |
@AhyoungRyu no, its under progress now. Should I change unchecked todo to other PR? |
@yoonjs2 yes i think it would be better to handle " L10N support" in other PR since it's a bit different work with this. What do you think? |
@AhyoungRyu Fair enough, I'd just removed a todo (L10N support) and It will be proposed different PR. |
@yoonjs2 Yeah thanks for your consideration! I've tested this branch and found some issues. 1.
seems it needs some markdown escaping. The line number 83 in
it can be fixed simply like below
then the error message will be gone :) 2. As you know, the docs site will be deployed under
and not happened in master. And also some styles are not missing now. Could you check them again? Please feel free to ping me if you're in trouble while testing. |
@AhyoungRyu OK I'll investigate and resolve them ASAP. Thanks for the review :) |
@AhyoungRyu I've stucked with the first step you've mentioned...
And I found few lines of your instruction seems mistyped... Am I correct?
|
@yoonjs2 Yeah you're right, there is a typo. It should be one of them either And you did like below as you said
But it should be in one line
|
Any updated? |
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
What is this PR for?
What type of PR is it?
Improvement | Documentation
Todos
What is the Jira issue?
ZEPPELIN-1554
Questions:
… style as kramdown.