Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SSL Cassandra support #1466

Closed
wants to merge 1 commit into from
Closed

Add SSL Cassandra support #1466

wants to merge 1 commit into from

Conversation

robertdkmarshall
Copy link

What is this PR for?

The Cassandra Interpreter does not support talking to clusters that use SSL/client to node encryption. It does not have the properties needed to configure the SSL Context. This PR adds the properties to the driver config and sets up the ssl options when they are requested.

What type of PR is it?

Improvement

Todos

  • - Task

What is the Jira issue?

https://issues.apache.org/jira/browse/ZEPPELIN-1501

How should this be tested?

Using CQL interpreter connect to a Cassandra cluster that uses client to node encryption.

Screenshots (if appropriate)

N/A

Questions:

  • Does the licenses files need update? No
  • Is there breaking changes for older versions? No
  • Does this need documentation? Yes. Should add the new properties to the list (cassandra.ssl.enabled, cassandra.ssl.truststore.path and cassandra.ssl.truststore.password).

@Leemoonsoo
Copy link
Member

\cc @doanduyhai

@doanduyhai
Copy link
Contributor

Ping @robertdkmarshall, any new from my code review ?

@doanduyhai
Copy link
Contributor

Without feedback I'll push a new PR with suggested code refactor & merge it in a few weeks @robertdkmarshall,

@jcam3ron
Copy link

Any update on whether this might be merged soon?

@doanduyhai
Copy link
Contributor

Let me redo the PR and merge with the above remarks included

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants