[ZEPPELIN-1624] HeliumApplicationFactoryTest fails on master #1603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Leemoonsoo
changed the title
…ource, classloading(regacy way)
Leemoonsoo
force-pushed
the
fix_helium_application_factory_test
branch
from
89b44a3
to
e511783
Compare
zjffdu
reviewed
Nov 8, 2016
| } catch (Throwable t) { | ||
| // nothing to do | ||
| registerInterpreterFromPath(interpreterDirString, interpreterJson); | ||
| registerInterpreterFromResource(cl, interpreterDirString, interpreterJson); |
There was a problem hiding this comment.
This would cause interpreter to be registered twice which make it difficult to configure the default interpreter setting. I change the method signature to return boolean to indicate whether it is registered successfully.
See my comments.
* Register interpreter by the following ordering
* 1. Register it from path {ZEPPELIN_HOME}/interpreter/{interpreter_name}/
* interpreter-setting.json
* 2. Register it from interpreter-setting.json in classpath
* {ZEPPELIN_HOME}/interpreter/{interpreter_name}
* 3. Register it by Interpreter.register
|
on Am I doing something wrong? |
|
@Leemoonsoo do you think it's worth re-basing on latest master? Tried My env |
|
ping @Leemoonsoo |
|
2 weeks ping @Leemoonsoo |
asfgit
pushed a commit
that referenced
this pull request
May 9, 2018
close #83 close #86 close #125 close #133 close #139 close #146 close #193 close #203 close #246 close #262 close #264 close #273 close #291 close #299 close #320 close #347 close #389 close #413 close #423 close #543 close #560 close #658 close #670 close #728 close #765 close #777 close #782 close #783 close #812 close #822 close #841 close #843 close #878 close #884 close #918 close #989 close #1076 close #1135 close #1187 close #1231 close #1304 close #1316 close #1361 close #1385 close #1390 close #1414 close #1422 close #1425 close #1447 close #1458 close #1466 close #1485 close #1492 close #1495 close #1497 close #1536 close #1545 close #1561 close #1577 close #1600 close #1603 close #1678 close #1695 close #1739 close #1748 close #1765 close #1767 close #1776 close #1783 close #1799
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
HeliumApplicationFactoryTest fails on master with following error if i run the test on local machine.
I'm fixing the issue by changing InterpreterFactory loads interpreter properties from interpreter-setting.json file, interpreter-setting.json classresource and Interpreter.register() call
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1624
How should this be tested?
try run HeliumApplicationFactoryTest unittest and see if it successes
Screenshots (if appropriate)
Questions: