Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZEPPELIN-277: Set the (TAB) key as an auto-completion shortcut #273

Closed
wants to merge 1 commit into from

Conversation

tzolov
Copy link
Contributor

@tzolov tzolov commented Sep 2, 2015

Oneliner fix that:

  • Sets (TAB) as the main auto-completion shortcut key.
  • Keeps the existing (Ctrl+.) shortcut for backward compatibility. We should define some deprecation period (0.6.0 release perhaps?)

@tzolov
Copy link
Contributor Author

tzolov commented Sep 4, 2015

This oneliner is ready for reviewing. It works excellent with the interpreters i've been using and really improves the UX perception.
But I wonder if there are interpreters (python?) for which the (tab) key is preferred to act as tab rather an auto-completion shortcut?

@Leemoonsoo
Copy link
Member

Thanks. I've tested this branch and the feature itself working well.
However, depends on language, TAB is not ideal for some language like python or scala. (for them '.' is more appropriate i think).

I think code editor need to get some informations from interpreter. Not only keyboard shortcuts for completion, but also like syntax highlight scheme and many more.

@felixcheung
Copy link
Member

+1 @Leemoonsoo https://issues.apache.org/jira/browse/ZEPPELIN-214
I think we should be good with this PR and track the bigger work on interpreter environment settings in a JIRA.

@Madhuka
Copy link
Contributor

Madhuka commented Sep 6, 2015

+1 to get syntax highlight for editor.
Since we can add new interpreters to zeppelin. It is important add plug auto-completion (js-hint) for editors.

Architecture of the auto-completion of editor need to extend-able as we have multiple interpreters.

@tzolov
Copy link
Contributor Author

tzolov commented Sep 6, 2015

@Leemoonsoo i expected that some interpreters would prefer to retain the tab key as a tab.

@felixcheung, to have this PR accepted and should i close it unresolved?

There are couple of other auto-completion related improvements like ZEPPELIN-139 , ZEPPELIN-214 that address the ability of the Interpreter to decides the ACE modes (and related highlight / completion features). Those though are dependent on ZEPPELIN-219 at the moment.

@tzolov tzolov force-pushed the ZEPPELIN-277 branch 3 times, most recently from fbe825c to 7a38fbb Compare September 10, 2015 07:31
@bzz
Copy link
Member

bzz commented Jan 5, 2016

@Leemoonsoo @felixcheung @tzolov shall we update this one and merge or close it?

@vinayshukla
Copy link
Contributor

@tzolov Thanks for your work on this. Are you still working on this? What is needed to complete this one?

@corneadoug
Copy link
Contributor

@tzolov Should we close this one?

@asfgit asfgit closed this in c38a0a0 May 9, 2018
asfgit pushed a commit that referenced this pull request May 9, 2018
close #83
close #86
close #125
close #133
close #139
close #146
close #193
close #203
close #246
close #262
close #264
close #273
close #291
close #299
close #320
close #347
close #389
close #413
close #423
close #543
close #560
close #658
close #670
close #728
close #765
close #777
close #782
close #783
close #812
close #822
close #841
close #843
close #878
close #884
close #918
close #989
close #1076
close #1135
close #1187
close #1231
close #1304
close #1316
close #1361
close #1385
close #1390
close #1414
close #1422
close #1425
close #1447
close #1458
close #1466
close #1485
close #1492
close #1495
close #1497
close #1536
close #1545
close #1561
close #1577
close #1600
close #1603
close #1678
close #1695
close #1739
close #1748
close #1765
close #1767
close #1776
close #1783
close #1799
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants