[ZEPPELIN-2148] On creation of Bar graph zeppelin UI shows it as minigraph - 2 #2092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…graph ### What is this PR for? On creation of Bar graph zeppelin UI shows it as mini graph, and is easily reproducible on safari. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-2148](https://issues.apache.org/jira/browse/ZEPPELIN-2148) ### How should this be tested? Check screen shot. ### Screenshots (if appropriate) Before:  After:  ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A Author: Prabhjyot Singh <prabhjyotsingh@gmail.com> Closes apache#2063 from prabhjyotsingh/ZEPPELIN-2148 and squashes the following commits: bb66897 [Prabhjyot Singh] replace setTimeOut with $timeout 38a1198 [Prabhjyot Singh] ZEPPELIN-2148: On creation of Bar graph zeppelin UI shows it as mini graph (reverted from commit 47a106a)
|
LGTM |
This was referenced Mar 8, 2017
1ambda
added a commit
to 1ambda/zeppelin
that referenced
this pull request
Mar 10, 2017
asfgit
pushed a commit
that referenced
this pull request
Mar 11, 2017
### What is this PR for? Can't display the same chart again. I attached a screenshot. - This should be backported into 0.7.0 as well. #### Implementation Details After #2092, - result.html will draw chart every time since we use `ng-if` instead of `ng-show` - that means DOM is deleted, and created too - so we have to create visualization instance every time which requires a newly created DOM. ```js builtInViz.instance = new Visualization(loadedElem, config); // `loadedElem` is the newly created DOM. ``` ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? I attached a screenshot ### Screenshots (if appropriate) ##### Before: buggy  ##### After: fixed  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes #2110 from 1ambda/ZEPPELIN-2234/cant-display-same-chart-again and squashes the following commits: 14ee617 [1ambda] fix: wait until DOM is loaded in renderDefaultDisplay func 42b5529 [1ambda] fix: Revert #2092
1ambda
added a commit
to 1ambda/zeppelin
that referenced
this pull request
Mar 15, 2017
asfgit
pushed a commit
that referenced
this pull request
Mar 16, 2017
### What is this PR for? Can't display the same chart again. I attached a screenshot. - this is the same fix with #2110 - except refactoring PR - based on branch-0.7 and - CI failure might be related with #2103 #### Implementation Details After #2092, - result.html will draw chart every time since we use `ng-if` instead of `ng-show` - that means DOM is deleted, and created too - so we have to create visualization instance every time which requires a newly created DOM. ```js builtInViz.instance = new Visualization(loadedElem, config); // `loadedElem` is the newly created DOM. ``` ### What type of PR is it? [Bug Fix] ### Todos NONE ### What is the Jira issue? * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/ * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533] ### How should this be tested? I attached a screenshot ### Screenshots (if appropriate) ##### Before: buggy  ##### After: fixed  ### Questions: * Does the licenses files need update? - NO * Is there breaking changes for older versions? - NO * Does this needs documentation? - NO Author: 1ambda <1amb4a@gmail.com> Closes #2114 from 1ambda/ZEPPELIN-2234/cant-display-same-chart-again-for-070 and squashes the following commits: 936123d [1ambda] fix: Retry until graph DOM is ready 475b532 [1ambda] fix: Reert #2092 for 0.7.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This is based on #2074 (comment).
In this I've reverted #47a106a and applied, that.
What type of PR is it?
[Bug Fix]
What is the Jira issue?
What is the Jira issue?
How should this be tested?
Check screen shot.
Screenshots (if appropriate)
Before:
After:
Questions: