[ZEPPELIN-6339] Fix - Anonymous users can access /login in the New UI, unlike the Classic UI #5087
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbonelee
reviewed
Oct 1, 2025
zeppelin-web-angular/e2e/tests/authentication/anonymous-login-redirect.spec.ts
Outdated
Show resolved
Hide resolved
dididy
force-pushed
the
fix/login-issue
branch
from
f897121 to
13a09d9
Compare
tbonelee
pushed a commit
that referenced
this pull request
Oct 3, 2025
…, unlike the Classic UI ### What is this PR for? #### [Classic UI] https://github.com/user-attachments/assets/9ae01649-5525-4310-b467-4dc96f205987 #### [As-Is] https://github.com/user-attachments/assets/654ce13a-1770-4c61-bc4c-c9cc09ba397d #### [To-Be] https://github.com/user-attachments/assets/9c8140e3-ff7f-4698-af93-8ae6859f6dee Anonymous users were able to access /login in the New UI, unlike the Classic UI. This has been restricted, and I have added tests to cover the change. ### What type of PR is it? Bug Fix ### Todos ### What is the Jira issue? ZEPPELIN-6339 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5087 from dididy/fix/login-issue. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 5484beb) Signed-off-by: ChanHo Lee <chanholee@apache.org>
|
Merged into master and branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
[Classic UI]
2025-09-28.4.17.01.mov
[As-Is]
2025-09-28.4.22.49.mov
[To-Be]
2025-09-28.4.43.48.mov
Anonymous users were able to access /login in the New UI, unlike the Classic UI.
This has been restricted, and I have added tests to cover the change.
What type of PR is it?
Bug Fix
Todos
What is the Jira issue?
ZEPPELIN-6339
How should this be tested?
Screenshots (if appropriate)
Questions: