[ZEPPELIN-6350] Fix Selenium test by Replacing Firefox with Edge #5089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbonelee
commented
Sep 30, 2025
Comment on lines
+117
to
+132
| - name: Set up JDK 11 | ||
| uses: actions/setup-java@v4 | ||
| with: | ||
| distribution: 'temurin' | ||
| java-version: 11 | ||
| - name: Cache local Maven repository | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: | | ||
| ~/.m2/repository | ||
| !~/.m2/repository/org/apache/zeppelin/ | ||
| ~/.spark-dist | ||
| ~/.cache | ||
| key: ${{ runner.os }}-zeppelin-${{ hashFiles('**/pom.xml') }} | ||
| restore-keys: | | ||
| ${{ runner.os }}-zeppelin- |
There was a problem hiding this comment.
I reverted this part to align it with other jobs
tbonelee
commented
Sep 30, 2025
| - name: Tune Runner VM | ||
| uses: ./.github/actions/tune-runner-vm | ||
| - name: Set up Edge browser | ||
| uses: browser-actions/setup-edge@v1 |
There was a problem hiding this comment.
Used official browser actions to setup Edge driver.
pan3793
reviewed
Oct 1, 2025
| return null; | ||
| } | ||
| }; | ||
| Supplier<WebDriver> edgeDriverSupplier = () -> { |
There was a problem hiding this comment.
please also update the comment at line 49
There was a problem hiding this comment.
I've added it, thanks!
pan3793
reviewed
Oct 1, 2025
.github/workflows/frontend.yml
Outdated
| -pl zeppelin-integration \ | ||
| -Pweb-classic -Pintegration -Pspark-scala-2.12 -Pspark-3.5 -Pweb-dist -Pusing-source-tree \ | ||
| ${MAVEN_ARGS} | ||
| xvfb-run --auto-servernum --server-args="-screen 0 1600x1024x16" ./mvnw verify -DfailIfNoTests=false -pl zeppelin-integration -Pweb-classic -Pintegration -Pspark-scala-2.12 -Pspark-3.5 -Pweb-dist -Pusing-source-tree ${MAVEN_ARGS} |
There was a problem hiding this comment.
what's wrong with the previous multi-line style?
There was a problem hiding this comment.
That was due to copy-pasting when reverting to the previous version, not intentional.
I've updated it back to the multi-line style as you suggested.
tbonelee
added a commit
that referenced
this pull request
Oct 2, 2025
### What is this PR for? This PR stabilizes the `test-selenium...` job by switching the Selenium browser from Firefox to Microsoft Edge. In #4941, we worked around a Linux ChromeDriver issue (SeleniumHQ/selenium#15358) by moving from Chrome to Firefox, but that workaround also seems to be not working well. I use Edge driver instead, since it does not have flakiness like Firefox driver and is more aligned with Chrome since it is also based on Chromium. Limitation: The root cause of Firefox browser failures has not been fully analyzed. ### What type of PR is it? Bug Fix ### What is the Jira issue? [[ZEPPELIN-6350]](https://issues.apache.org/jira/browse/ZEPPELIN-6350) ### How should this be tested? - Check `test-selenium...` job in `frontend` ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5089 from tbonelee/fix-selenium-test. Signed-off-by: Chan Lee <chanho0325@gmail.com> (cherry picked from commit 3d1ee7c) Signed-off-by: Chan Lee <chanho0325@gmail.com>
|
Thanks for the reviews. I've merged this into master and branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR for?
This PR stabilizes the
test-selenium...job by switching the Selenium browser from Firefox to Microsoft Edge.In #4941, we worked around a Linux ChromeDriver issue (SeleniumHQ/selenium#15358) by moving from Chrome to Firefox, but that workaround also seems to be not working well.
I use Edge driver instead, since it does not have flakiness like Firefox driver and is more aligned with Chrome since it is also based on Chromium.
Limitation: The root cause of Firefox browser failures has not been fully analyzed.
What type of PR is it?
Bug Fix
What is the Jira issue?
[ZEPPELIN-6350]
How should this be tested?
test-selenium...job infrontendQuestions: