[CI-Hotfix] Remove not allowed action in Selenium test #5093
+14
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dididy
approved these changes
Oct 2, 2025
There was a problem hiding this comment.
https://github.com/apache/zeppelin/actions/runs/18196900468/job/51805424251?pr=5093
It seems works well. LGTM!
tbonelee
added a commit
that referenced
this pull request
Oct 3, 2025
I attempted to create a related JIRA issue, but the Apache JIRA site isn't working for an hour. Therefore, I’m proceeding without creating the issue. ### What is this PR for? Currently, our CI workflow uses browser-actions/setup-edge<at>v1 to install Microsoft Edge. However, this action is not allowed in the apache/zeppelin repository because only actions from approved/verified sources can be used. <img width="2109" height="241" alt="image" src="https://github.com/user-attachments/assets/28b0e90a-ffaf-41b4-9c25-495088a20963" /> To resolve this, I removed the external action and replace it with a direct installation step. ### What type of PR is it? Bug Fix ### How should this be tested? - Check if CI works ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5093 from tbonelee/remove-not-allowed-action. Signed-off-by: ChanHo Lee <chanholee@apache.org> (cherry picked from commit 7c7b00f) Signed-off-by: ChanHo Lee <chanholee@apache.org>
|
Thanks! Merged into master and branch-0.12 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I attempted to create a related JIRA issue, but the Apache JIRA site isn't working for an hour. Therefore, I’m proceeding without creating the issue.
What is this PR for?
Currently, our CI workflow uses browser-actions/setup-edge@v1 to install Microsoft Edge. However, this action is not allowed in the apache/zeppelin repository because only actions from approved/verified sources can be used.
To resolve this, I removed the external action and replace it with a direct installation step.
What type of PR is it?
Bug Fix
How should this be tested?
Questions: