Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ZOOKEEPER-3987: Reduce fork count for tests to 1 #1606

Closed
wants to merge 1 commit into from
Closed

ZOOKEEPER-3987: Reduce fork count for tests to 1 #1606

wants to merge 1 commit into from

Conversation

ctubbsii
Copy link
Member

@ctubbsii ctubbsii commented Feb 16, 2021 •
edited
Loading

Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

@ctubbsii
ZOOKEEPER-3987: Reduce fork count for tests to 1
bebe714 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.
eolivelli
eolivelli approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
I am happy with this proposal as it is fixing the errors

@ztzg @anmolnar PTAL
I hope this can unblock 3.7 release

ztzg
ztzg approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@ztzg ztzg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. (Not "LGTM," because this is a crude workaround, but let's get moving :)

(Also: this is obviously not a criticism of @ctubbsii's help, which is very welcome. Still planning to do some work on the root cause ASAP.)

@frederiko frederiko mentioned this pull request Feb 17, 2021
Closed
@ztzg ztzg closed this in c26f96c Feb 17, 2021
ztzg pushed a commit that referenced this pull request Feb 17, 2021
@ctubbsii @ztzg
ZOOKEEPER-3987: Reduce fork count for tests to 1
5ae153c 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes #1606 from ctubbsii/reduce-forkCount

(cherry picked from commit c26f96c)
Signed-off-by: Damien Diederen <ddiederen@apache.org>
ztzg pushed a commit that referenced this pull request Feb 17, 2021
@ctubbsii @ztzg
ZOOKEEPER-3987: Reduce fork count for tests to 1
351deb8 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes #1606 from ctubbsii/reduce-forkCount

(cherry picked from commit c26f96c)
Signed-off-by: Damien Diederen <ddiederen@apache.org>
@ztzg
Copy link
Contributor

ztzg commented Feb 17, 2021

Picked into master, branch-3.7 and branch-3.7.0. Thank you, @ctubbsii! I also hope this is good enough for us to get 3.7 out!

@ctubbsii ctubbsii deleted the reduce-forkCount branch February 17, 2021 21:00
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3987: Reduce fork count for tests to 1
ab435c9 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3987: Reduce fork count for tests to 1
a92f6d5 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Aug 31, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3987: Reduce fork count for tests to 1
14c6842 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 3, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3987: Reduce fork count for tests to 1
16bf11e 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount
RokLenarcic pushed a commit to RokLenarcic/zookeeper that referenced this pull request Sep 29, 2022
@ctubbsii @RokLenarcic
ZOOKEEPER-3987: Reduce fork count for tests to 1
f73c387 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount
anuragmadnawat1 pushed a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 2, 2022
@ctubbsii @anurag-harness
ZOOKEEPER-3987: Reduce fork count for tests to 1
93a21f3 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount
@anuragmadnawat1 anuragmadnawat1 mentioned this pull request Nov 2, 2022
Merged
anuragmadnawat1 added a commit to anuragmadnawat1/zookeeper that referenced this pull request Nov 2, 2022
@anuragmadnawat1 @ctubbsii
ZOOKEEPER-3987: Reduce fork count for tests to 1 (#102)
0d4ad45 
Increase test stability by avoiding test failures due to port
collisions by preventing tests from running concurrently in
the GitHub Actions CI builds.

Author: Christopher Tubbs <ctubbsii@apache.org>

Reviewers: Enrico Olivelli <eolivelli@apache.org>, Damien Diederen <ddiederen@apache.org>

Closes apache#1606 from ctubbsii/reduce-forkCount

Co-authored-by: Christopher Tubbs <ctubbsii@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ztzg ztzg ztzg approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctubbsii @ztzg @eolivelli