[ZOOKEEPER-3116] Make the DataTree.approximateDataSize more efficient #594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lvfangmin I this is a very good improvement. Do you think that existing unit tests cover this functionality or it might be beneficial to add some? |
|
@lvfangmin You got a findbugs warning: |
|
Thanks @anmolnar, I've updated the code to read the node.data inside the synchronized section. I'll check the Findbugs result for the updated patch. |
|
@anmolnar the updated code has passed all the tests and no Findbugs warning. |
|
@anmolnar I think this should be ready to go in now. |
|
Committed to master. |
RokLenarcic
pushed a commit
to RokLenarcic/zookeeper
that referenced
this pull request
Sep 3, 2022
Cache the approximate data tree size, and update it when txns applied to data tree, this could make this query not that expensive. Author: Fangmin Lyu <allenlyu@fb.com> Reviewers: andor@apache.org Closes apache#594 from lvfangmin/ZOOKEEPER-3116 and squashes the following commits: ad2ce21 [Fangmin Lyu] move to synchronize when visiting node.data 2e0cbb1 [Fangmin Lyu] add test case to test cached approximate data tree size 21243f5 [Fangmin Lyu] cache the approximate data size in DataTree
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache the approximate data tree size, and update it when txns applied to data tree, this could make this query not that expensive.