-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checksum-dependency-plugin for verification of plugin/dependency checksums #4256
Conversation
Thank you so much for opening your first pull request here! |
Travis fails as follows: https://travis-ci.org/apereo/cas/jobs/583054385#L777
It would be interesting to know why Travis resolves different json-smart jars. |
It turns out checksum mismatch for |
274c21c
to
b223b58
Compare
…checksums `checksum-dependency-plugin` is a superset of `gradle-witness`, and it enables to increase the level of security. See https://github.com/vlsi/vlsi-release-plugins#checksum-dependency-plugin Note: GPars is signed with 74DAFDFD6DAE2441, however it is not available on pulic key servers: GPars/GPars#62 Note: SpringFramework misses PGP keys, see spring-projects/spring-framework#23434
This patch has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This patch has been automatically closed because it has not had recent activity. If you wish to resume work, please re-open the pull request and continue as usual. Thank you for your contributions. |
checksum-dependency-plugin
is a superset ofgradle-witness
, and it enables to increase the level of security.See https://github.com/vlsi/vlsi-release-plugins#checksum-dependency-plugin
See https://medium.com/@vladimirsitniko/dependency-verification-checksum-vs-pgp-582e76207019?sk=7485298b76eaf9f935b899b002f4c3b5
Relevant pull request is #1752
The idea behind the change is to add verification so the set of dependencies.
It is configured with
checksum.xml
file. The plugin prints detailed message in case of failure, and it generates updatedchecksum.xml
file (its location is included to the message).Here's sample failure (I removed the artifact from checksum.xml so it fails on "unknown" artifact):
Another sample: walleth/walleth#396 (comment)
Note: GPars is signed with 74DAFDFD6DAE2441, however it is not available on pulic key servers:
GPars/GPars#62
That is why 74DAFDFD6DAE2441 is added to
ignored-keys
for now.Note: SpringFramework misses PGP keys, see spring-projects/spring-framework#23434