Fix preserve url anchor #5371
Closed
Fix preserve url anchor #5371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes regression introduced in commit 984dfaf "fix issue with mfa not keeping request params"
(location.hash is either empty or starts with "#")
|
This pull request has been open and inactive for 7 days. It will be closed shortly. |
|
NB: applied in 6.6.x with commit c00d8b0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since CAS 5.2, hash param in url is added twice to login submit url. Example of resulting url: #foo=bar#foo=bar
The regression comes from commit 984dfaf (*) , "queryParams" is added to "action". Then "hash" is added to "action". The issue is that "queryParams" contains both the query params AND the hash.
This pull request uses
location.searchto fix the issue.It has been tested in production (for CAS protocol).
(*) backported to 5.2 5.3 6.0 52d5fb2