fix redis ticket registry bean type #5577
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #5577 +/- ##
=====================================================
+ Coverage 91.83826% 91.84609% +0.00783%
- Complexity 17650 17651 +1
=====================================================
Files 2792 2792
Lines 68037 68041 +4
Branches 4887 4887
=====================================================
+ Hits 62484 62493 +9
+ Misses 2643 2640 -3
+ Partials 2910 2908 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Have you also tested the pub/sub functionality with the bean change and confirmed that it continues to work ok? |
|
The change you made last week that set Lazy to false for the whole class also fixes this issue. I suppose that is because Spring can see the actual type of the bean rather than the declared type that doesn't match the argument type? Intellij is complaining that |
|
You might be correct there. We could register the topic dynamically if it starts to cause serious issues with laziness but I would prefer to keep an outer type as an interface to help with proxies. Can revisit if it shows up again. I am curious as to why this was not caught in puppeteer tests. All should run with lazy-beans activated. I'll take a second look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am working on trying to re-create (locally with puppeteer test) cas in k8s talking to redis sentinel cluster in k8s, b/c I don't think CAS recovers from redis master changing. and this bean was failing unless I changed argument type to
Topic(changing bean type toChannelTopicalso worked). Not sure why it works in existing tests, but my test just hasreportsandredis-ticket-registry.