Skip to content

Conversation

thabarbados
Copy link
Collaborator

Fix or Enhancement?

Create Charts for Vue2, add tests and sandboxes for these charts.

  • All tests passed

Environment

  • OS: BigSur MacOs
  • NPM Version: 8.5.1

@thabarbados thabarbados requested a review from dangreen March 18, 2022 13:23
@github-actions
Copy link

github-actions bot commented Mar 18, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/index.cjs 1.2 KB (-97.91% 🔽) 24 ms (-97.91% 🔽) 54 ms (+60.66% 🔺) 78 ms
dist/index.js 1.07 KB (-86.15% 🔽) 22 ms (-86.15% 🔽) 45 ms (+237.5% 🔺) 67 ms

Copy link
Collaborator

@dangreen dangreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All legacy components are under "legacy" dir - maybe we will not use "legacy" prefix for components names?

@thabarbados thabarbados requested a review from dangreen March 21, 2022 10:07
@thabarbados thabarbados requested a review from dangreen March 23, 2022 08:04
@thabarbados thabarbados requested a review from dangreen March 23, 2022 09:47
@dangreen dangreen merged commit 5c9a69c into main Mar 23, 2022
@dangreen dangreen deleted the create-vue2-charts branch March 23, 2022 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants