Validator throws Uncaught PHP Exception

[divine]

API Platform version(s) affected: 3.2.1

Custom validation throws an Uncaught PHP Exception

[2023-10-21T10:21:01.781619+00:00] request.CRITICAL: Uncaught PHP Exception ApiPlatform\Symfony\Validator\Exception\ValidationException: "field: The field is not valid." at /apiplatform/vendor/api-platform/core/src/Symfony/Validator/Validator.php line 60

Description

How to reproduce

Create a custom validation and then check the error log.

Possible Solution

Custom validation error shouldn't throw Uncaught PHP Exception

Additional Context

Probably code is empty and it's the reason why it's throwing error:

{
	"status": 422,
	"violations": [
		{
			"propertyPath": "field",
			"message": "The data \"test\" is not valid.",
			"code": null
		}
	],
	"detail": "field: The data \"test\" is not valid.",
	"type": "\/validation_errors\/00000000000004b00000000000000000",
	"title": "An error occurred"
}

[soyuka]

I don't understand please give me a stack trace or more informations, is there something that doesn't work? My logs show:

[Web Server ] Oct 26 19:40:08 |WARN   | SERVER POST (422) /dummies

[divine]

I don't understand please give me a stack trace or more informations, is there something that doesn't work? My logs show:

[Web Server ] Oct 26 19:40:08 |WARN   | SERVER POST (422) /dummies

Hello,

I'm using MongoDB, that might be the reason?

{▼
  /app/vendor/api-platform/core/src/Symfony/Validator/Validator.php:60 {▼
    ApiPlatform\Symfony\Validator\Validator->validate(object $data, array $context = []): void …
    › if (0 !== \count($violations)) {
    ›     throw new ValidationException($violations);
    › }
  }
  /app/vendor/api-platform/core/src/Symfony/Validator/State/ValidateProvider.php:42 {▼
    ApiPlatform\Symfony\Validator\State\ValidateProvider->provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null …
    › 
    › $this->validator->validate($body, $operation->getValidationContext() ?? []);
    › 
    arguments: {▶}
  }
  /app/vendor/api-platform/core/src/Symfony/Security/State/AccessCheckerProvider.php:53 {▼
    ApiPlatform\Symfony\Security\State\AccessCheckerProvider->provide(Operation $operation, array $uriVariables = [], array $context = []): object|array|null …
    › 
    › $body = $this->decorated->provide($operation, $uriVariables, $context);
    › if (null === $isGranted) {
    arguments: {▶}
  }
  /app/vendor/api-platform/core/src/State/Provider/ContentNegotiationProvider.php:56 {▶}
  /app/vendor/api-platform/core/src/Symfony/Controller/MainController.php:74 {▼
    ApiPlatform\Symfony\Controller\MainController->__invoke(Request $request): Response …
    › 
    › $body = $this->provider->provide($operation, $uriVariables, $context);
    › 
    arguments: {▼
      $operation: ApiPlatform\Metadata\Post {[#927](https://localhost/_profiler/4c5b9b?panel=logger#sf-dump-489581687-ref2927) …}
      $uriVariables: []
      $context: [ …3]
    }
  }
  /app/vendor/symfony/http-kernel/HttpKernel.php:181 {▼
    Symfony\Component\HttpKernel\HttpKernel->handleRaw(Request $request, int $type = self::MAIN_REQUEST): Response …
    › // call controller
    › $response = $controller(...$arguments);
    › 
    arguments: {▶}
  }
  /app/vendor/symfony/http-kernel/HttpKernel.php:76 {▼
    Symfony\Component\HttpKernel\HttpKernel->handle(Request $request, int $type = HttpKernelInterface::MAIN_REQUEST, bool $catch = true): Response …
    › try {
    ›     return $response = $this->handleRaw($request, $type);
    › } catch (\Throwable $e) {
    arguments: {▼
      $request: Symfony\Component\HttpFoundation\Request {[#2](https://localhost/_profiler/4c5b9b?panel=logger#sf-dump-489581687-ref22) …}
      $type: 1
    }
  }
  /app/vendor/symfony/http-kernel/Kernel.php:197 {▼
    Symfony\Component\HttpKernel\Kernel->handle(Request $request, int $type = HttpKernelInterface::MAIN_REQUEST, bool $catch = true): Response …
    › try {
    ›     return $this->getHttpKernel()->handle($request, $type, $catch);
    › } finally {
    arguments: {▶}
  }
  /app/vendor/symfony/runtime/Runner/Symfony/HttpKernelRunner.php:35 {▼
    Symfony\Component\Runtime\Runner\Symfony\HttpKernelRunner->run(): int …
    › {
    ›     $response = $this->kernel->handle($this->request);
    ›     $response->send();
    arguments: {▶}
  }
  /app/vendor/autoload_runtime.php:29 {▼
    require_once …
    ›         ->getRunner($app)
    ›         ->run()
    › );
  }
  /app/public/index.php:5 {▼
    › 
    › require_once dirname(__DIR__).'/vendor/autoload_runtime.php';
    › 
    arguments: {▼
      "/app/vendor/autoload_runtime.php"
    }
  }
}

[divine]

Server in production returns Uncaught PHP Exception for not found URLs as well:

request.ERROR: Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException:

"No route found for "DELETE http://localhost/4" (from "http://localhost/")" at /srv/apiplatform/vendor/symfony/http-kernel/EventListener/RouterListener.php line 127

{"exception":"[object (Symfony\\Component\\HttpKernel\\Exception\\NotFoundHttpException(code: 0): No route found for \"DELETE http://localhost/4\" (from \"http://localhost\/") at /srv/apiplatform/vendor/symfony/http-kernel/EventListener/RouterListener.php:127)\n

[previous exception] [object (Symfony\\Component\\Routing\\Exception\\ResourceNotFoundException(code: 0): No routes found for \"/4\". at /srv/apiplatform/vendor/symfony/routing/Matcher/Dumper/CompiledUrlMatcherTrait.php:74)"} []

So it's indeed something is broken with error handling.

Also:

[2023-10-27T22:07:25.025475+00:00] request.CRITICAL: Uncaught PHP Exception TypeError: "ApiPlatform\Metadata\ResourceClassResolver::isResourceClass(): Argument #1 ($type) must be of type string, null given, called in /srv/apiplatform/vendor/api-platform/core/src/Serializer/AbstractItemNormalizer.php on line 396" at /srv/apiplatform/vendor/api-platform/core/src/Metadata/ResourceClassResolver.php line 94

{"exception":"[object] (TypeError(code: 0): ApiPlatform\\Metadata\\ResourceClassResolver::isResourceClass(): Argument #1 ($type) must be of type string, null given, called in /srv/apiplatform/vendor/api-platform/core/src/Serializer/AbstractItemNormalizer.php on line 396 at /srv/apiplatform/vendor/api-platform/core/src/Metadata/ResourceClassResolver.php:94)"} []

[2023-10-27T22:07:25.026056+00:00] php.CRITICAL: Uncaught Error: ApiPlatform\Metadata\ResourceClassResolver::isResourceClass(): Argument #1 ($type) must be of type string, null given, called in /srv/apiplatform/vendor/api-platform/core/src/Serializer/AbstractItemNormalizer.php on line 396

{"exception":"[object] (TypeError(code: 0): ApiPlatform\\Metadata\\ResourceClassResolver::isResourceClass(): Argument #1 ($type) must be of type string, null given, called in /srv/apiplatform/vendor/api-platform/core/src/Serializer/AbstractItemNormalizer.php on line 396 at /srv/apiplatform/vendor/api-platform/core/src/Metadata/ResourceClassResolver.php:94)"} []

Thanks!

[soyuka]

I took a look but we just go through https://github.com/symfony/symfony/blob/6c3d3770c166711a9440778ae43f06999c668292/src/Symfony/Component/HttpKernel/EventListener/ErrorListener.php#L93 not sure that it's a bug I need to check if 3.1 also had that.

[soyuka]

okay found it, ValidationException had no HttpExceptionInterface implemented therefore symfony was logging as critical!

[alebedev80]

@soyuka i've upgrade to 3.2.7 but still ERROR log level and "Uncaught PHP Exception"

request.ERROR: Uncaught PHP Exception ApiPlatform\Symfony\Validator\Exception\ValidationException