[3.2] Bc break with exception handling

[lyrixx]

API Platform version(s) affected: 3.2

In 3.1, when an exception occurs, Symfony set the _controller (in ErrorListener) to api_platform.action.exception
In 3.2 it's api_platform.symfony.main_controller.

There is a drawback, because in my exception, I have some headers, and there are not replicated anymore in the final response.

How to reproduce

throw new TooManyRequestsHttpException(32);

And see the is not "Retry-After" header in the response

Possible Solution

• revert the change
• or add support for header duplication in the MainController

[lyrixx]

Thanks 💛

[lyrixx]

I tried to update to 3.2.5, and I still get an error in my test:

$response = $this->client->getResponse();
$this->assertSame(429, $response->getStatusCode());

$retryAfter = (int) $response->headers->get('Retry-After');
$this->assertTrue($retryAfter > 0 && $retryAfter <= 60);

$decoded = json_decode((string) $response->getContent(), true);
$errorMessage = $decoded['detail'];
$this->assertStringStartsWith('You have reached the usage limit of 5 requests in 1 minute for the API token.', $errorMessage);

=>

1) Tests\Functional\Api\PublicApi\RateLimiterSubscriberTest::testApiTokenRateLimit
Failed asserting that 'Too Many Requests' starts with "You have reached the usage limit of 5 requests in 1 minute for the API token.".

In our code we have:

throw new TooManyRequestsHttpException($delaySeconds, sprintf($this->exceptionMessage, $limit->getLimit(), $this->tokenInterval, 'API token', $delaySeconds));