[Laravel] Auto-Configuration Instantiates Dependencies Too Early

[cay89]

API Platform version(s) affected: 4.1.1

It's probably because of "auto configure our tagged interfaces" that I'm encountering an issue where, if I pass a dependency to a ProcessorInterface-implementing class via the constructor—one that I configure in my own AppServiceProvider—it results in an error. This happens because it tries to instantiate the class before my AppServiceProvider runs.

This is how it looks:

class MyDependency
{
    public function __construct(
        private readonly string $param,
    ) {
    }
}

class ExampleProcessor implements ProcessorInterface
{
    public function __construct(
        private readonly MyDependency $dependency,
    ) {
    }
    
    public function process(
        mixed $data,
        Operation $operation,
        array $uriVariables = [],
        array $context = [],
    ) {
        // do something with $this->dependency
    }
}

class AppServiceProvider extends ServiceProvider
{
    public function register(): void
    {
        $this->app->singleton(
            MyDependency::class,
            fn() => new MyDependency(
                config('my_dependency.param'),
            ),
        );
    }
}

So this is now causing an error like this:

PHP Fatal error: Uncaught Illuminate\Contracts\Container\BindingResolutionException: Unresolvable dependency resolving [...] in class ... in /app/vendor/laravel/framework/src/Illuminate/Container/Container.php:1231

I would also be fine with keeping the previous approach somehow, where I manually register my ProcessorInterface / ProviderInterface classes in my own AppServiceProvider, as that previously worked:

class AppServiceProvider extends ServiceProvider
{
    public function register(): void
    {
        $this->app->singleton(
            MyDependency::class,
            fn() => new MyDependency(
                config('my_dependency.param'),
            ),
        );
        $this->app->tag([ExampleProcessor::class], ProcessorInterface::class);
    }
}

[soyuka]

That's weird, I don't see why tag would run the creation of the singleton. I'll test this further thanks for the bug report!