[RFR] Improve autowiring #1152
Merged
[RFR] Improve autowiring #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunglas
approved these changes
Jun 1, 2017
meyerbaptiste
requested changes
Jun 1, 2017
| @@ -13,6 +13,11 @@ | |||
|
|
|||
| namespace ApiPlatform\Core\Bridge\Symfony\Bundle\DependencyInjection; | |||
|
|
|||
| use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryCollectionExtensionInterface; | |||
| use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface; | |||
| use ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\FilterInterface; | |||
There was a problem hiding this comment.
It should be ApiPlatform\Core\Api\FilterInterface.
| @@ -13,14 +13,20 @@ | |||
|
|
|||
| namespace ApiPlatform\Core\Tests\Bridge\Symfony\Bundle\DependencyInjection; | |||
|
|
|||
| use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryCollectionExtensionInterface; | |||
| use ApiPlatform\Core\Bridge\Doctrine\Orm\Extension\QueryItemExtensionInterface; | |||
| use ApiPlatform\Core\Bridge\Doctrine\Orm\Filter\FilterInterface; | |||
There was a problem hiding this comment.
It should be ApiPlatform\Core\Api\FilterInterface.
|
I'm just thinking about something: filters require |
|
It's not required anymore because of #862. |
|
Most of the filters you'd declare in your app are from API Platform anyway, so PSR-4 service discovery and autowiring (there's nothing to be wired up) doesn't really help. |
teohhanhui
approved these changes
Jun 1, 2017
meyerbaptiste
approved these changes
Jun 1, 2017
dunglas
approved these changes
Jun 1, 2017
|
Thank you @vincentchalamon! |
hoangnd25
pushed a commit
to hoangnd25/core
that referenced
this pull request
Feb 23, 2018
[RFR] Improve autowiring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.