Disable eager loading when no groups are specified to avoid recursive joins #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
force-pushed
the
fix-eager-loading-without-groups
branch
from
927c2ec to
bae8b67
Compare
dunglas
requested changes
Jun 5, 2018
| @@ -107,6 +107,10 @@ private function apply(bool $collection, QueryBuilder $queryBuilder, QueryNameGe | |||
| $context += $this->getNormalizationContext($context['resource_class'] ?? $resourceClass, $contextType, $options); | |||
| } | |||
|
|
|||
| if (empty($context[AbstractNormalizer::GROUPS])) { | |||
There was a problem hiding this comment.
&& !isset(AbstractNormalizer::ATTRIBUTES)
soyuka
force-pushed
the
fix-eager-loading-without-groups
branch
from
bae8b67 to
000f6df
Compare
teohhanhui
changed the title
dunglas
approved these changes
Jun 5, 2018
teohhanhui
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.