Skip to content

Update PHP-CS-Fixer rules #2005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 8, 2018
Merged

Update PHP-CS-Fixer rules #2005

merged 2 commits into from
Jun 8, 2018

Conversation

teohhanhui
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

@teohhanhui teohhanhui requested review from dunglas and soyuka June 6, 2018 15:26
teohhanhui
teohhanhui commented Jun 6, 2018
View reviewed changes
.php_cs.dist
'phpdoc_order' => true,
'psr4' => true,
'semicolon_after_instruction' => true,
// 'simplified_null_return' => true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may be able to use this rule once we require at least PHP 7.1 and have the nullable return type declarations in place. But it might not be possible to have a return type declaration in all cases...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that master requires >=7.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm aware of that. Will try turning this rule on in master.

@dunglas dunglas merged commit ec4e0cb into api-platform:2.2 Jun 8, 2018
@dunglas
Copy link
Member

dunglas commented Jun 8, 2018

Thanks @@teohhanhui!

@teohhanhui teohhanhui deleted the update-php-cs-fixer-rules branch June 8, 2018 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soyuka soyuka soyuka approved these changes

@dunglas dunglas Awaiting requested review from dunglas

+1 more reviewer

@bendavies bendavies bendavies left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@teohhanhui @dunglas @bendavies @soyuka