Hal Item Normalizer: add a local cache for classMetadataFactory #2010
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soyuka
reviewed
Jun 9, 2018
| @@ -169,7 +170,11 @@ private function getComponents($object, string $format = null, array $context) | |||
| private function populateRelation(array $data, $object, string $format = null, array $context, array $components, string $type): array | |||
| { | |||
| $class = \get_class($object); | |||
| $attributesMetadata = $this->classMetadataFactory ? $this->classMetadataFactory->getMetadataFor($object)->getAttributesMetadata() : null; | |||
| $cacheKey = $class.':attribute-metadata'; | |||
There was a problem hiding this comment.
Can you declare a const CACHE_SUFFIX with this constatnt?
There was a problem hiding this comment.
cache suffix isn't needed. removed it.
soyuka
reviewed
Jun 9, 2018
|
|
||
| $attributesMetadata = \array_key_exists($cacheKey, $this->attributesMetadataCache) ? | ||
| $this->attributesMetadataCache[$cacheKey] : | ||
| $this->attributesMetadataCache[$cacheKey] = $this->classMetadataFactory ? $this->classMetadataFactory->getMetadataFor($object)->getAttributesMetadata() : null; | ||
|
|
There was a problem hiding this comment.
Why not $attributesMetadata = $this->attributesMetadataCache[$cacheKey] ?? this->classMetadataFactory ? $this->classMetadataFactory->getMetadataFor($object)->getAttributesMetadata() : null;
There was a problem hiding this comment.
can't do this, null coalesce doesn't work with null, so the array_key_exists is needed.
|
Weird circleci issue, may you force push to trigger the build? |
|
all good @soyuka |
soyuka
approved these changes
Jun 11, 2018
|
Thanks @bendavies! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
here: #1971 i accidentally created a performance issue.
I didn't spot this because the (prod) cached metadata factory does not have a local lookup:
https://github.com/symfony/symfony/blob/1b2bd8f41971f7903fd04d898801a1874a0427dc/src/Symfony/Component/Serializer/Mapping/Factory/CacheClassMetadataFactory.php#L46
while the (dev) uncached one does:
https://github.com/symfony/symfony/blob/1b2bd8f41971f7903fd04d898801a1874a0427dc/src/Symfony/Component/Serializer/Mapping/Factory/ClassMetadataFactory.php#L44-L48
This means that in prod mode, many many cache lookups are done, which is pretty slow.
This PR adds a local cache to fix that excessive lookups.