fix issue #1717 - Support Subresources MaxDepth for yaml and xml #2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code coverage seems to have an issue: https://codecov.io/gh/api-platform/core/pull/2019/diff It seems it doesn't take into account |
soyuka
approved these changes
Jun 13, 2018
|
Thanks for the bug fix, can you target the |
|
The diff is weird, you need to rebase on 2.2 I think |
|
It's when I change target from master to 2.2 If I rebase it messed up everything.... EDIT: I finally achieved to rebase properly but I lost my other PR in the procedure... I will recreate it quickly when it is fresh in my head... |
Nightbr
force-pushed
the
fix-subresourceMaxDepth-xml-yaml
branch
from
7e66193 to
8760548
Compare
Nightbr
force-pushed
the
fix-subresourceMaxDepth-xml-yaml
branch
from
8760548 to
c7c4f3b
Compare
soyuka
requested changes
Jun 13, 2018
| @@ -146,13 +146,15 @@ private function createSubresourceMetadata($subresource, PropertyMetadata $prope | |||
| if (null !== $type) { | |||
| $isCollection = $type->isCollection(); | |||
| $resourceClass = $isCollection ? $type->getCollectionValueType()->getClassName() : $type->getClassName(); | |||
| $maxDepth = null; // for Type we can't configure maxDepth, maxDepth is always null | |||
There was a problem hiding this comment.
can you declare this var l145 instead?
we don't need the comment, null is default anyway
soyuka
approved these changes
Jun 14, 2018
|
Thanks @Nightbr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it needed more integration in Extractor and Property Factory in order to use Subresources MaxDepth.
I have update related test cases.
Question about Type class which is used in ExtractorPropertyMetadataFactory:
$type = $propertyMetadata->getType();It uses the built-in symfony Type class and we can't retrieve maxDepth info. So I set maxDepth to null in this case. If you have better idea.