Fix: max depth not working when fetch eager is disabled #2215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanpoulain
force-pushed
the
fix/hal-not-eager-max-depth
branch
3 times, most recently
from
8738d5d to
f456bdb
Compare
|
Looks good to me, but it breaks an existing test. Can you add a new set of entities instead of modifying the existing one? |
alanpoulain
force-pushed
the
fix/hal-not-eager-max-depth
branch
from
7329cdd to
18dbd5c
Compare
|
Done! |
soyuka
approved these changes
Oct 1, 2018
|
Thanks Alan! |
epourail
pushed a commit
to epourail/fork-apiplatform-core
that referenced
this pull request
Oct 7, 2018
…#2215) * Add failing test * Fix HAL normalizer
blanky0230
pushed a commit
to blanky0230/core
that referenced
this pull request
Oct 11, 2018
…#2215) * Add failing test * Fix HAL normalizer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max depth annotation was not working in HAL when fetch eager was disabled.