Fix Bug Preventing Denormalization of Input Classes with Different Fields #2490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ragboyjr
changed the title
dunglas
approved these changes
Feb 3, 2019
Fixes the bug where AbstractItemSerializer would use the resource class instead of the input class to determine allowed properties. Enforced `$context['resource_class']` to be set to current denormalized class to resolve issue. Figured this should be the case since AbstractItemNormalizer only works on resources. Signed-off-by: RJ Garcia <rj@bighead.net>
ragboyjr
force-pushed
the
denormalize-input-class-with-different-fields
branch
from
52da0eb to
391e9df
Compare
|
@dunglas CS fixed. Squashed and pushed up. |
|
Thanks @ragboyjr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug where AbstractItemSerializer would use
the resource class instead of the input class to
determine allowed properties.
Enforced
$context['resource_class']to be set tocurrent denormalized class to resolve issue. Figured this
should be the case since AbstractItemNormalizer only works
on resources.
Signed-off-by: RJ Garcia rj@bighead.net