Skip to content

Fix HTTP status code when output class is set to null #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2019

Conversation

teohhanhui
Copy link
Contributor

@teohhanhui teohhanhui commented Apr 18, 2019

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A

Also fix Behat test for when input class is set to null.

@teohhanhui teohhanhui force-pushed the fix/null-output-class-http-204 branch 5 times, most recently from 9f4c790 to 7fe1c36 Compare April 18, 2019 17:12
@teohhanhui teohhanhui force-pushed the fix/null-output-class-http-204 branch 2 times, most recently from be7f97b to c645a88 Compare April 18, 2019 18:22
@teohhanhui teohhanhui force-pushed the fix/null-output-class-http-204 branch from c645a88 to dd61305 Compare April 18, 2019 18:24
Copy link
Contributor

@antograssiot antograssiot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few minor comments 👍

@soyuka soyuka merged commit 9222ded into api-platform:2.4 Apr 19, 2019
@soyuka
Copy link
Member

soyuka commented Apr 19, 2019

Thanks @teohhanhui !

@teohhanhui teohhanhui deleted the fix/null-output-class-http-204 branch April 19, 2019 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants