Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MongoDB Bundle detection #2862

Merged
merged 1 commit into from
Jun 15, 2019
Merged

Improve MongoDB Bundle detection #2862

merged 1 commit into from
Jun 15, 2019

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Jun 15, 2019

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@dunglas dunglas merged commit 08bb437 into api-platform:2.4 Jun 15, 2019
@dunglas dunglas deleted the improve-mongodb-config branch June 15, 2019 11:09
teohhanhui
teohhanhui reviewed Jun 17, 2019
View reviewed changes
tests/Fixtures/app/AppKernel.php
@@ -137,6 +137,19 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load

$c->loadFromExtension('security', $securityConfig);

if (class_exists(DoctrineMongoDBBundle::class)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but it's very weird for us to add use statements for the bundles. I mean, it's not usually done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teohhanhui teohhanhui teohhanhui left review comments

@alanpoulain alanpoulain alanpoulain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dunglas @teohhanhui @alanpoulain