Improve MongoDB Bundle detection #2862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Jun 15, 2019
dunglas
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
| Doc PR | n/a |
dunglas
force-pushed
the
improve-mongodb-config
branch
from
6b0962d to
3557fd8
Compare
alanpoulain
approved these changes
Jun 15, 2019
teohhanhui
reviewed
Jun 17, 2019
| @@ -137,6 +137,19 @@ protected function configureContainer(ContainerBuilder $c, LoaderInterface $load | |||
|
|
|||
| $c->loadFromExtension('security', $securityConfig); | |||
|
|
|||
| if (class_exists(DoctrineMongoDBBundle::class)) { | |||
There was a problem hiding this comment.
Unrelated, but it's very weird for us to add use statements for the bundles. I mean, it's not usually done?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.