Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : Throw a better message if http-client is not installed #2994

Merged
merged 1 commit into from Aug 19, 2019

Conversation

@Zowac
Copy link

commented Aug 19, 2019

Q A
Bug fix? no
New feature? Yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2982
License MIT
Doc PR api-platform/doc#1234

@Zowac Zowac force-pushed the Zowac:throw-better-message branch from ad1b120 to dc6b746 Aug 19, 2019

@soyuka
soyuka approved these changes Aug 19, 2019

@dunglas dunglas merged commit 204c21a into api-platform:master Aug 19, 2019

10 of 13 checks passed

codecov/patch 50% of diff hit (target 91.41%)
Details
codecov/project 91.4% (-0.01%) compared to e8f26ca
Details
SymfonyInsight: dunglas / API Platform Core Your analysis has been queued.
Scrutinizer Analysis: No new issues – Tests: passed
Details
ci/circleci: behat-coverage Your tests passed on CircleCI!
Details
ci/circleci: behat-elasticsearch-coverage Your tests passed on CircleCI!
Details
ci/circleci: behat-mongodb-coverage Your tests passed on CircleCI!
Details
ci/circleci: php-cs-fixer Your tests passed on CircleCI!
Details
ci/circleci: phpstan Your tests passed on CircleCI!
Details
ci/circleci: phpunit-coverage Your tests passed on CircleCI!
Details
ci/circleci: phpunit-mongodb-coverage Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@dunglas

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Thanks @Zowac!

@dunglas

This comment has been minimized.

Copy link
Member

commented Aug 19, 2019

Actually, I've probably be too fast to merge. It would be better to throw here: https://github.com/api-platform/core/blob/master/src/Bridge/Symfony/Bundle/Test/ApiTestCase.php#L44

Currently the exception will be triggered for every Symfony application not having the HttpClient installed, even if it doesn't use our test client.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.