Skip to content

Fix : Throw a better message if http-client is not installed #2994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2019
Merged

Fix : Throw a better message if http-client is not installed #2994

merged 1 commit into from
Aug 19, 2019

Conversation

Zowac
Copy link
Contributor

@Zowac Zowac commented Aug 19, 2019

Q A
Bug fix? no
New feature? Yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #2982
License MIT
Doc PR api-platform/docs#1234

dunglas
dunglas requested changes Aug 19, 2019
View reviewed changes
@dunglas dunglas merged commit 204c21a into api-platform:master Aug 19, 2019
@dunglas
Copy link
Member

dunglas commented Aug 19, 2019

Thanks @Zowac!

@dunglas
Copy link
Member

dunglas commented Aug 19, 2019

Actually, I've probably be too fast to merge. It would be better to throw here: https://github.com/api-platform/core/blob/master/src/Bridge/Symfony/Bundle/Test/ApiTestCase.php#L44

Currently the exception will be triggered for every Symfony application not having the HttpClient installed, even if it doesn't use our test client.

@dunglas dunglas mentioned this pull request Aug 19, 2019
Merged
@teohhanhui teohhanhui mentioned this pull request Aug 29, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas dunglas approved these changes

@soyuka soyuka soyuka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zowac @dunglas @soyuka